Skip to content

Add support for Symfony 6 components #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

racastellanosm
Copy link
Contributor

Adding support for Symfony 6.x option resolver component to avoid failing installs on Symfony 6.x projects.

Adding support for Symfony 6.x option resolver component to avoid failing installs on Symfony 6.x projects.
@racastellanosm
Copy link
Contributor Author

Hi @dantleech thanks for you project.

This PR is intended also to produce a new tag for phpbench:phpbench main project because as today it's has a installation conflict with projects with Symfony 6.x

Do you need that i open a new PR on phpbench:phpbench project referencing this issue?

Regards

@dantleech
Copy link
Member

ach, I thought PHPBench already supported 6.x but I guess options resolver was indeed held back.

@dantleech dantleech merged commit addf35d into phpbench:master Jan 25, 2022
@dantleech
Copy link
Member

Tagged 2.2.1, should be fine now i guess

@racastellanosm
Copy link
Contributor Author

Works perfect now! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants