chore: fix many clippy lints

[VuiMuich]

Poking around your repo got me in the mood of fixing some clippy lints, so I ran

> cargo clippy --fix --allow-dirty -- -D warnings -W clippy::pedantic -A clippy::missing_errors_doc -A clippy::missing_panics_doc -A clippy::too_many_lines

and fixed everything remaining except those two:

    Checking impala v0.2.4 (/home/vuimuich/Git/impala)
warning: wildcard matches only a single variant and will also match any future added variants
   --> src/access_point.rs:164:13
    |
164 |             _ => Text::from("  SSID name"),
    |             ^ help: try: `APFocusedSection::PSK`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants
    = note: `-D clippy::match-wildcard-for-single-variants` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::match_wildcard_for_single_variants)]`

warning: wildcard matches only a single variant and will also match any future added variants
   --> src/access_point.rs:169:13
    |
169 |             _ => Text::from("  SSID password"),
    |             ^ help: try: `APFocusedSection::SSID`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants

warning: `impala` (lib) generated 2 warnings
warning: `impala` (lib test) generated 2 warnings (2 duplicates)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.30s

[VuiMuich]

Ok -A clippy::must_use_candidate would have been a good addition in the first place...

[pythops]

I am wondering why this is not good enough

cargo clippy --workspace --all-features -- -D warnings

that's what configured in the CI ?

I am open for a better CI ofc

[VuiMuich]

It is absolutely find for a ci runner to have a bit more relaxed clippy lints imo.
Personally I find it helpful to run clippy pedantic every now and then to keep up with the latest improvements.
I see it more like a lesson for me, to improve code style.

I totally see, how this PR might be seen as slightly offensive and I want to sincerely apologize, that was in no way my intention, nor was it to show off or something. I just was - as I said - in the mood for a little clippy pedantic session on a repo, where the necessary fixes looked like they won't involve huge refactoring.

[pythops]

Personally I find it helpful to run clippy pedantic every now and then to keep up with the latest improvements.

Good point

I totally see, how this PR might be seen as slightly offensive and I want to sincerely apologize

No, it is not offensive and there is no need to apologize.

I will look at it today, thanks for the PR 🙏

[pythops]

Thanks again for the PR buddy

[VuiMuich]

You are very welcome and also thanks again for the merge.