Sign petition with an account

[lpoujade]

Proposition for #99 : auto fill petition's signature form with currently connected user, if any, else leave form empty

[fallen]

Looks great, thanks!

[fallen]

This looks great!
Could you add one unit test for this new feature?
Just check that if a user is logged in, its personal information are displayed in the HTML form and that

form.is_bound == True

?

[lpoujade]

yep !

[fallen]

I can see you've rebased on origin/master.
Are you having troubles writing the unit test? I can write it if you want.
If you just lack time for this PR no worries then we can just wait :)

[lpoujade]

yes i just don't had the time until this week, i finish that at the end of the week :)
sorry for the delay !

[fallen]

Absolutely no problem!
I just wanted to ping to see if there was an issue I could help with :)
No hurry and no worry!
Thanks for your help :)

[lpoujade]

So it's been a long week

I'm not sure if I should add a test in tests_PetitionViews.py as in my last commit or in tests_CreateSignatureView.py, could you give me a hint ? Maybe I should post the form before checking it ? Thank

[fallen]

Hey @lpoujade , long time no see! ;)
It's nice to see you getting back at playing with Pytition again!

I think that your change is mostly touching the Petition view (petition_detail.html template + slug_show_petition view)
so you are not creating a signature, so I think it's OK like this with testing in tests_PetitionViews.py

However I think you should also add your code inside the detail view.
Maybe this code should have a refactor to limit code duplication, but indeed there are -as of today- two entry points to petition_detail.html template:

• either by the unique petition ID (detail view): less readable URL but much smaller/compact => https://github.com/pytition/Pytition/blob/master/pytition/petition/views.py#L166
• or by org name/user name + petition slug (slug_show_petition view): much longer URL but much nicer to read => https://github.com/pytition/Pytition/blob/master/pytition/petition/views.py#L1575

[fallen]

need to update detail view as well before merging.