[do not merge] RNTuple Attributes prototype #19153
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 3d 7h 1m 24s ⏱️ For more details on these failures, see this check. Results for commit 95e7500. ♻️ This comment has been updated with latest results. |
This currently only works for a subset of cases, namely if all RNTuples have the same set of Attribute Sets.
Otherwise the build fails on some platforms due to unordered_map requiring a complete type for the value type
jblomer
reviewed
Jul 4, 2025
Comment on lines
+693
to
+694
| The payload of each list element is a Locator pointing to the Attribute RNTuple's Anchor followed by a string | ||
| containing the Attribute Set's name. |
There was a problem hiding this comment.
The locator and the name should be in a record frame, so that we can extend it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Draft PR for the RNTuple Attributes prototype.
This prototype allows writing, reading and merging TFile-based RNTuples containing Attributes. Note that the implementation is not final and cuts several corners in order to provide a proof of concept.
Note that this new optional feature requires the Binary Format to be bumped by one minor version.