-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] examine the status of h2root on Windows #19184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 20 files 20 suites 3d 14h 17m 37s ⏱️ Results for commit da78596. |
I see on Windows CI: could you check locally? or install gfortran on that Windows image? |
Classic. That's why we like |
FYI, there is no gfortran for Windows |
Right, sorry, the Intel-Fortran compiler. |
It doesn't work. I guess I should try to fix it, but what is the priority? |
Low priority. One question though: is it h2root failing, or is the it just not compiling / the fortran compiler giving errors? My hunch was that sometimes the Intel compilers discover bugs, so maybe the errors that Windows give can help in debugging the failures on MacOs. |
Yes it's not important to get it to work on WIndows per se, but these errors on macOS are quite worrying. I think |
Short: CMake didn't find the compiler, and when specifying it, the compileer didn't pass the CMake tests at configure time. But I'll give it another try today |
So FYI I tried hard the whole day to build with Intel Fortran compiler, but it mess up the environment for C++, and mixing languages don't work, with this kind of error:
I'll try to debug this next week, but I'm not very optimistic... |
we can also decide not to provide h2root on windows. |
we can also decide not to provide h2root on windows. If one wishes to play with lep data and convert them to ROOT format on Windows, wsl is available. |
Yep, I agree. This was more an attempt to see if compiling h2root with Intel gave more insightful warnings that helped to debug the macOS crashes. (Things such as access after end of list or so). |
Thanks! It seems ifx does not like whitespaces in the compiler folder name. Any way to rename that folder, or to escape those whitespaces? |
I'll try to figure out and find a workaround. The issue is the inclusion with Visual Studio (hence the PATH - and without that it doesn't work) |
We don't provide h2root on Windows. It was working in the past with ROOT 5 when using makefiles in the cygwin environmemt, but never tried with CMake, and this is the major issue I have now... |
Thanks a lot for checking. In that case, would it work to compile it on Windows using the old Makefiles from ROOT5 ? (Or just via the command line by hand, compiling the involved files one after the other?) Since I was just interested in seeing if if it raises any compiler warnings when compiling zebra.f and hbook.f especially. |
No warning at all. But I didn't find how to specify the warning level... Looking into it now |
OK, I found |
@ferdymercury no relevant warnings, only plenty of warnings like:
|
Thanks a lot! Did you remove the -w flag? (see d8215a8) Or maybe it does not apply to Windows. If possible, please attach a zip file with the warnings :) |
Here are the logs |
Thanks! Closing for the moment. |
This Pull request:
Changes or fixes:
Check if h2root works on Windows.
if yes, @bellenot can you run the h2root test in a Debug build of Windows?