Skip to content

[roottest] examine the status of h2root on Windows #19184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Check if h2root works on Windows.

if yes, @bellenot can you run the h2root test in a Debug build of Windows?

@ferdymercury ferdymercury requested a review from bellenot as a code owner June 26, 2025 05:45
Copy link

Test Results

    20 files      20 suites   3d 14h 17m 37s ⏱️
 3 045 tests  3 045 ✅ 0 💤 0 ❌
59 310 runs  59 310 ✅ 0 💤 0 ❌

Results for commit da78596.

@ferdymercury
Copy link
Collaborator Author

I see on Windows CI:
2025-06-26T05:50:00.1510211Z -- Looking for a Fortran compiler - NOTFOUND

could you check locally? or install gfortran on that Windows image?
Thanks!

@guitargeek
Copy link
Contributor

guitargeek commented Jun 26, 2025

Classic. That's why we like fail-on-missing:

@bellenot
Copy link
Member

I see on Windows CI: 2025-06-26T05:50:00.1510211Z -- Looking for a Fortran compiler - NOTFOUND

could you check locally? or install gfortran on that Windows image? Thanks!

FYI, there is no gfortran for Windows

@ferdymercury
Copy link
Collaborator Author

I see on Windows CI: 2025-06-26T05:50:00.1510211Z -- Looking for a Fortran compiler - NOTFOUND
could you check locally? or install gfortran on that Windows image? Thanks!

FYI, there is no gfortran for Windows

Right, sorry, the Intel-Fortran compiler.

@bellenot
Copy link
Member

I see on Windows CI: 2025-06-26T05:50:00.1510211Z -- Looking for a Fortran compiler - NOTFOUND
could you check locally? or install gfortran on that Windows image? Thanks!

FYI, there is no gfortran for Windows

Right, sorry, the Intel-Fortran compiler.

It doesn't work. I guess I should try to fix it, but what is the priority?

@ferdymercury
Copy link
Collaborator Author

It doesn't work. I guess I should try to fix it, but what is the priority?

Low priority. One question though: is it h2root failing, or is the it just not compiling / the fortran compiler giving errors?

My hunch was that sometimes the Intel compilers discover bugs, so maybe the errors that Windows give can help in debugging the failures on MacOs.

@guitargeek
Copy link
Contributor

Yes it's not important to get it to work on WIndows per se, but these errors on macOS are quite worrying. I think h2root needs to be reliable, otherwise we risk to corrupt data from the LEP era when converting to ROOT :(

@bellenot
Copy link
Member

It doesn't work. I guess I should try to fix it, but what is the priority?

Low priority. One question though: is it h2root failing, or is the it just not compiling / the fortran compiler giving errors?

Short: CMake didn't find the compiler, and when specifying it, the compileer didn't pass the CMake tests at configure time. But I'll give it another try today

@bellenot
Copy link
Member

So FYI I tried hard the whole day to build with Intel Fortran compiler, but it mess up the environment for C++, and mixing languages don't work, with this kind of error:

Compiling with Intel® Fortran Compiler 2025.2.0 [Intel(R) 64]...
g2root.f
ifx: command line warning #10161: unrecognized source type 'Files\Microsoft'; object file assumed
ifx: command line warning #10161: unrecognized source type 'Visual'; object file assumed
fpp: fatal: can't fopen file: Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostX64\x64 /Qm64 C:\root-dev\git\master\main\src\g2root.f

I'll try to debug this next week, but I'm not very optimistic...

@dpiparo
Copy link
Member

dpiparo commented Jun 30, 2025

we can also decide not to provide h2root on windows.

@dpiparo
Copy link
Member

dpiparo commented Jun 30, 2025

we can also decide not to provide h2root on windows. If one wishes to play with lep data and convert them to ROOT format on Windows, wsl is available.

@ferdymercury
Copy link
Collaborator Author

Yep, I agree. This was more an attempt to see if compiling h2root with Intel gave more insightful warnings that helped to debug the macOS crashes. (Things such as access after end of list or so).

@ferdymercury
Copy link
Collaborator Author

So FYI I tried hard the whole day to build with Intel Fortran compiler, but it mess up the environment for C++, and mixing languages don't work, with this kind of error:

Compiling with Intel® Fortran Compiler 2025.2.0 [Intel(R) 64]...
g2root.f
ifx: command line warning #10161: unrecognized source type 'Files\Microsoft'; object file assumed
ifx: command line warning #10161: unrecognized source type 'Visual'; object file assumed
fpp: fatal: can't fopen file: Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostX64\x64 /Qm64 C:\root-dev\git\master\main\src\g2root.f

I'll try to debug this next week, but I'm not very optimistic...

Thanks! It seems ifx does not like whitespaces in the compiler folder name. Any way to rename that folder, or to escape those whitespaces?

@bellenot
Copy link
Member

Thanks! It seems ifx does not like whitespaces in the compiler folder name. Any way to rename that folder, or to escape those whitespaces?

I'll try to figure out and find a workaround. The issue is the inclusion with Visual Studio (hence the PATH - and without that it doesn't work)

@bellenot
Copy link
Member

we can also decide not to provide h2root on windows. If one wishes to play with lep data and convert them to ROOT format on Windows, wsl is available.

We don't provide h2root on Windows. It was working in the past with ROOT 5 when using makefiles in the cygwin environmemt, but never tried with CMake, and this is the major issue I have now...

@ferdymercury
Copy link
Collaborator Author

Thanks a lot for checking. In that case, would it work to compile it on Windows using the old Makefiles from ROOT5 ? (Or just via the command line by hand, compiling the involved files one after the other?) Since I was just interested in seeing if if it raises any compiler warnings when compiling zebra.f and hbook.f especially.

@bellenot
Copy link
Member

No warning at all. But I didn't find how to specify the warning level... Looking into it now

@bellenot
Copy link
Member

OK, I found /warn:all, but then it is very verbose...

@bellenot
Copy link
Member

bellenot commented Jun 30, 2025

@ferdymercury no relevant warnings, only plenty of warnings like:

C:\root-dev\git\master\misc\minicern\src\zebra.f(7213): warning #8889: Explicit interface or EXTERNAL declaration is required.   [MZGARB]
      CALL MZGARB (0,IXWIPE)
-----------^
[...]
--------------------------------------------^
C:\root-dev\git\master\misc\minicern\src\zebra.f(7207): warning #6717: This name has not been given an explicit type.   [IQVREM]
      COMMON /ZVFAUT/IQVID(2),IQVSTA,IQVLOG,IQVTHR(2),IQVREM(2,6)
------------------------------------------------------^
C:\root-dev\git\master\misc\minicern\src\zebra.f(7209): remark #7712: This variable has not been used.   [NAMESR]
      DIMENSION    NAMESR(2)
-------------------^

@ferdymercury
Copy link
Collaborator Author

ferdymercury commented Jun 30, 2025

Thanks a lot! Did you remove the -w flag? (see d8215a8) Or maybe it does not apply to Windows.

If possible, please attach a zip file with the warnings :)

@bellenot
Copy link
Member

Here are the logs
ifx-logs.zip

@ferdymercury
Copy link
Collaborator Author

Thanks! Closing for the moment.

@ferdymercury ferdymercury deleted the patch-12 branch July 1, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants