[root.exe] Use non-zero exit status when invalid arguments are passed

[hageboeck]

Followup to #19195:
RDF IMT tutorials didn't run since 10 months, since the following passed with a 0 exit status:

$ root '-e "ROOT::EnableImplicitMT(4)"' ...
root: unrecognized option '-e "ROOT::EnableImplicitMT(4)"'
Try 'root --help' for more information.
  2965/2993 Test tutorial-analysis-dataframe-df102_NanoAODDimuonAnalysis ............. Passed 0.15 sec

To avoid similar problem in the future, I suggest here to exit with a non-zero exit status. I chose 2 because 1 usually means that the script/macro/command that was running in the interpreter failed:

bin/root -b -q -e "invalid"; echo $?
1

Whereas a failure to parse the argument would now be:

$ root '-e "ROOT::EnableImplicitMT(4)"'; echo $?
2

[vepadulano]

Why is this test removed?

[hageboeck]

Because I cannot make it pass. Now that TApplication exits with status 2, the end of this test cannot be reached. It will always fail.

It is replaced by

 add_test(NAME root_exitStatus COMMAND $<TARGET_FILE:root.exe> "-e invalid")
 set_property(TEST root_exitStatus PROPERTY WILL_FAIL TRUE)

which admittedly doesn't test the error message, but it does test that root exits with != 0

[pcanal]

LGTM.

Side note: The RUFF does not seem to handle well deleted files, see:
https://github.com/root-project/root/actions/runs/15901873603/job/44846574695?pr=19196
which says:

Run files=$(cat changed_files.txt | grep '\.py$' || echo "")
Error: tutorials/.enableImplicitMTWrapper.py:1:1: E902 No such file or directory (os error 2)
Error: Process completed with exit code 123.

[github-actions]

Test Results

    20 files      20 suites   3d 12h 53m 49s ⏱️
 3 067 tests  3 067 ✅ 0 💤 0 ❌
59 740 runs  59 740 ✅ 0 💤 0 ❌

Results for commit 4720fd7.

♻️ This comment has been updated with latest results.

[hageboeck]

LGTM.

Side note: The RUFF does not seem to handle well deleted files, see: https://github.com/root-project/root/actions/runs/15901873603/job/44846574695?pr=19196 which says:

Run files=$(cat changed_files.txt | grep '\.py$' || echo "")
Error: tutorials/.enableImplicitMTWrapper.py:1:1: E902 No such file or directory (os error 2)
Error: Process completed with exit code 123.

@pcanal I had noticed the same, but this problem was fixed in the mean time here: #19197