-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cernlib] avoid asan warning / maybe undefined behavior in h2root #19200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
reported by asan /opt/root_src/misc/minicern/src/cernlib.c:82:18: runtime error: left shift of negative value -2012982016 /opt/root_src/misc/minicern/src/cernlib.c:83:18: runtime error: left shift of negative value -2012982016 /opt/root_src/misc/minicern/src/cernlib.c:102:12: runtime error: left shift of 1212370737 by 8 places cannot be represented in type 'int' /opt/root_src/misc/minicern/src/cernlib.c:102:39: runtime error: left shift of 1212370737 by 24 places cannot be represented in type 'int'
There is still this warning:
which I am not sure how to solve. Aside: And in the past I also got this one:
And if I unsilence the compile warnings (d8215a8) I get:
Very rarely (just once) I got this debug stacktrace (2158 in my debug build was at line
Mac15 CI with -O0 removed but -g active:
|
Test Results 20 files 20 suites 3d 8h 20m 12s ⏱️ Results for commit 9b628ac. ♻️ This comment has been updated with latest results. |
Hi, I'd propose merging this as-is and moving the pending warnings to a new GH issue to keep track of those. |
This Pull request:
Changes or fixes:
reported by asan