[Hist] Generalize TF1 constructor using C++17 #19203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the requirement was that the wrapped function had a call
operator that *exactly* took C-style arrays as arguments.
To be more general, we check if the function can be invoked with C-style
arrays as arguments, even if implicit conversions are involved. This is
done using `std::is_invocable_r_v` from C++17.
Care was taken that the detection of vectorized functions still works,
which can be tested like this (requires `veccore` and `vc`):
```c++
// Modified reproducer from ROOT-10251
auto originalFF = [](ROOT::Double_v *x , double *par){ (void)par; return *x; };
auto boundFF = std::bind (originalFF,std::placeholders::_1, std::placeholders::_2);
TF1 myFitFunct("myFitFunct", boundFF,0, 1 , 0 );
myFitFunct.Print("v");
std::cout << myFitFunct.IsVectorized() << std::endl;
```
Closes https://its.cern.ch/jira/browse/ROOT-10251.
Test Results 20 files 20 suites 3d 22h 40m 56s ⏱️ Results for commit 49085ee. |
dpiparo
approved these changes
Jun 27, 2025
|
Thank you @guitargeek !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the requirement was that the wrapped function had a call operator that exactly took C-style arrays as arguments.
To be more general, we check if the function can be invoked with C-style arrays as arguments, even if implicit conversions are involved. This is done using
std::is_invocable_r_vfrom C++17.Care was taken that the detection of vectorized functions still works, which can be tested like this (requires
veccoreandvc):Closes https://its.cern.ch/jira/browse/ROOT-10251.