Skip to content

feat: adding annCollection dataloader #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ori-kron-wis
Copy link
Collaborator

based on #3018

@ori-kron-wis ori-kron-wis self-assigned this May 29, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label May 29, 2025
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 75.36232% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.92%. Comparing base (0cfa925) to head (5b6a5cf).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_anncollection.py 75.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3362      +/-   ##
==========================================
- Coverage   78.93%   78.92%   -0.02%     
==========================================
  Files         208      209       +1     
  Lines       18931    19000      +69     
==========================================
+ Hits        14943    14995      +52     
- Misses       3988     4005      +17     
Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/dataloaders/_anncollection.py 75.00% <75.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis requested a review from canergen June 4, 2025 17:24
@canergen
Copy link
Member

canergen commented Jun 5, 2025

There seems to be more legacy. Can your remove all and tag me? I can have another look then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants