Skip to content

fix: scVIVA test names, minify functions #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ori-kron-wis
Copy link
Collaborator

fix testing names, minify in scviva

@ori-kron-wis ori-kron-wis self-assigned this Jun 8, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label Jun 8, 2025
@ori-kron-wis ori-kron-wis requested a review from LevyNat June 8, 2025 12:46
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (0cfa925) to head (d31eb72).

❗ There is a different number of reports uploaded between BASE (0cfa925) and HEAD (d31eb72). Click for more details.

HEAD has 44 uploads less than BASE
Flag BASE (0cfa925) HEAD (d31eb72)
47 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   86.32%   79.00%   -7.33%     
==========================================
  Files         208      208              
  Lines       18931    18908      -23     
==========================================
- Hits        16343    14938    -1405     
- Misses       2588     3970    +1382     
Files with missing lines Coverage Δ
src/scvi/external/scviva/_model.py 93.78% <ø> (+7.67%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants