Skip to content

High-level diagram of the python-slack-sdk #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ivanmilevtues
Copy link

Summary

Generated documentation to help new developers to get to know the python-slack-sdk (from the stand point of contributors).

Let me know what is your opinion on the generated diagrams, do they fit in your existing process of on-boarding people to new codebases?

Any feedback is more than welcome!

Full disclosure: we're trying to turn this into a startup, but we're still in a very early stage and figuring out what will actually be useful for people.

Testing

This is pure documentation contribution, so no testing is needed!

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

salesforce-cla bot commented Jun 4, 2025

Thanks for the contribution! Before we can merge this, we need @ivanmilevtues to sign the Salesforce Inc. Contributor License Agreement.

@ivanmilevtues
Copy link
Author

I signed the CLA, however the label is still on the PR.
Can someone take a look?

@zimeg zimeg closed this Jun 4, 2025
@zimeg zimeg reopened this Jun 4, 2025
@zimeg zimeg added docs M-T: Documentation work only discussion M-T: An issue where more input is needed to reach a decision labels Jun 4, 2025
@zimeg
Copy link
Member

zimeg commented Jun 4, 2025

Hey @ivanmilevtues! 👋 This is so interesting - thanks for sharing 📚 ✨

I haven't reviewed all of the docs for correctness at this time, but I'm hesitant to include generated documentation for contributors as markdown when inline reference can serve similar purpose with a better chance of being updated with related edits?

I am so curious about what others think and am wondering aloud if these notes could be generated as needed instead? 🤖

@ivanmilevtues
Copy link
Author

ivanmilevtues commented Jun 4, 2025

Thanks for the response @zimeg! I think the inline references are awesome further they are something that most repo's don't have. However we strive to give an overview of the project structure and allow newcomers to grasp the main components and how they interact with each other - I personally really like looking at diagrams rather than reading docs :).

I would love to see what the community thinks on this idea in general. So thank you for putting the discussion and docs labels <3

@WilliamBergamin
Copy link
Contributor

I side with @zimeg here, I am also hesitant to include more generated documentation in this project 🤔
I also think we should keep our dependencies to a minimum in order to help maintainers in their work

@ivanmilevtues
Copy link
Author

@WilliamBergamin, I understand your point and if you think it is not the place for it. Just on the maintainers side, we are just finishing our GitHub action which will keep the docs automatically up-to-date. Lmk how that sounds to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed discussion M-T: An issue where more input is needed to reach a decision docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants