Skip to content

Commit 8f4d172

Browse files
committed
oops, type hint didn't go there. :)
1 parent bdd6aed commit 8f4d172

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

code/ch8-async-databases/.idea/ch8-async-databases.iml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

code/ch8-async-databases/bin/load_data.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def find_users(data: List[dict]) -> dict:
107107

108108
with progressbar.ProgressBar(max_value=len(data)) as bar:
109109
for idx, p in enumerate(data):
110-
info = p.get('info')
110+
info = p.get('info', {})
111111
found_users.update(get_email_and_name_from_text(info.get('author'), info.get('author_email')))
112112
found_users.update(get_email_and_name_from_text(info.get('maintainer'), info.get('maintainer_email')))
113113
bar.update(idx)
@@ -181,7 +181,7 @@ def load_package(data: dict, user_lookup: Dict[str, User]):
181181

182182
p.author = info.get('author')
183183
p.author_email = info.get('author_email')
184-
p.license = detect_license(info.get('license'))
184+
p.license = detect_license(info.get('license')) or 'MIT'
185185

186186
session = db_session.create_session()
187187
session.add(p)
@@ -227,7 +227,7 @@ def build_releases(package_id: str, releases: dict) -> List[Release]:
227227

228228
r = Release()
229229
r.package_id = package_id
230-
r.major_ver, r.minor_ver, r.build_ver = make_version_num(k)
230+
r.major_ver, r.minor_ver, r.build_ver = make_version_num(k) # type: ignore[reportGeneralTypeIssues]
231231
r.created_date = parse(v.get('upload_time'))
232232
r.comment = v.get('comment_text')
233233
r.url = v.get('url')

code/ch8-async-databases/services/user_service.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,14 @@ async def user_count() -> int:
1515
return result.scalar()
1616

1717

18-
async def create_account(name: str, email: str, password: str) -> User:
18+
async def create_account(name: Optional[str], email: Optional[str], password: Optional[str]) -> User:
19+
if not password:
20+
raise Exception('password is required')
21+
if not email:
22+
raise Exception('email is required')
23+
if not name:
24+
raise Exception('name is required')
25+
1926
user = User()
2027
user.email = email
2128
user.name = name

code/ch8-async-databases/views/account.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ async def index(request: Request):
2323

2424
@router.get('/account/register', include_in_schema=False)
2525
@template()
26-
def register(request: Request):
26+
def register_get(request: Request):
2727
vm = RegisterViewModel(request)
2828
return vm.to_dict()
2929

3030

3131
@router.post('/account/register', include_in_schema=False)
3232
@template()
33-
async def register(request: Request):
33+
async def register_post(request: Request):
3434
vm = RegisterViewModel(request)
3535
await vm.load()
3636

0 commit comments

Comments
 (0)