generate-types: Fix canBeOptional computation in parseSignature #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A parameter can be optional if *all* of the following parameters are optional. This fixes several instances of “error TS1016: A required parameter cannot follow an optional parameter” if you try to regenerate the types for webpack with strictNullChecks enabled. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
canBeOptional
branch
from
17641d4 to
ab6d2aa
Compare
|
This was merged as 6a5ad8b without attribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A parameter can be optional if all of the following parameters are optional.
This fixes several instances of “error TS1016: A required parameter cannot follow an optional parameter” if you try to regenerate the types for webpack with
strictNullChecksenabled.