feat!: Replace web-ext with @wxt-dev/runner
#1700
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
aklinker1
commented
Jun 2, 2025
Comment on lines
+10
to
+14
| if (wxt.config.browser === 'firefox' && wxt.config.manifestVersion === 3) { | ||
| throw Error( | ||
| 'Dev mode does not support Firefox MV3. For alternatives, see https://github.com/wxt-dev/wxt/issues/230#issuecomment-1806881653', | ||
| ); | ||
| } |
There was a problem hiding this comment.
TODO: Extract to own PR.
aklinker1
commented
Jun 2, 2025
| @@ -3,7 +3,7 @@ import { debug } from './debug'; | |||
|
|
|||
| const debugBidi = debug.scoped('bidi'); | |||
|
|
|||
| export interface BidiConnection extends Disposable { | |||
There was a problem hiding this comment.
TODO: Extract disposable changes to own PR.
5 tasks
aklinker1
commented
Jun 2, 2025
| DEFAULT_CHROMIUM_PREFS, | ||
| ), | ||
| args: [ | ||
| '--unsafely-disable-devtools-self-xss-warnings', |
There was a problem hiding this comment.
TODO: Add this flag?
This was referenced Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
web-exthas few problems:web-ext-run)--load-extension, which has been deprecated (there are plans to upgrade to using the CDP, like@wxt-dev/runner, but it hasn't been implemented yet)../scripts/benchmarks/browser-startup.sh)web-ext@wxt-dev/runnerTODO
Manual Testing
This should open your browser.
Related Issue
N/A