Skip to content

Commit 01f94ab

Browse files
committed
YB: workaround to fix 004_pg_dump_parallel.pl test
Test 004_pg_dump_parallel.pl was introduced by commit 2b216da, which states that it teaches pg_dump to apply load-via-partition-root automatically when detecting hash-on-enum partitioning. For some reason, importing commit 96a81c1 causes this detection to stop working. This causes the test to fail. Given YB backup/restore usually uses --include-yb-metadata which causes enum oids and sort orders to be preserved, YB doesn't really need load-via-partition-root nor the automatic detection. Therefore, ignore the failing auto detection for now and just fix the test by manually passing --load-via-partition-root to pg_dump. In the future, this issue will naturally go away as YB merges to future versions beyond 96a81c1. At that point, this test change should be discarded.
1 parent 7b10ddb commit 01f94ab

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/bin/pg_dump/t/004_pg_dump_parallel.pl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
$node->command_ok(
5050
[
5151
'pg_dump', '-Fd', '--no-sync', '-j2', '-f', "$backupdir/dump1",
52+
'--load-via-partition-root',
5253
$node->connstr($dbname1)
5354
],
5455
'parallel dump');
@@ -66,6 +67,7 @@
6667
'pg_dump', '-Fd',
6768
'--no-sync', '-j2',
6869
'-f', "$backupdir/dump2",
70+
'--load-via-partition-root',
6971
'--inserts', $node->connstr($dbname1)
7072
],
7173
'parallel dump as inserts');

0 commit comments

Comments
 (0)