Skip to content

Commit 769c7ef

Browse files
committed
YB: manually add missing items to typedefs.list
Do a test run of pgindent, manually find types that should be in typedefs.list, exclude any that do not also belong in the typedefs.list of recent master (commit 8ede692 at the time of writing), then add those types to typedefs.list. Note the following types that were intentionally not included in the list: - ResultRelInfoExtra: introduced by commit 3706cc9, this type only exists in the back-patch branch and not master. - EPQStateExtra: introduced by commit 4729d1e, this type only exists in the back-patch branch and not master. - LWLockWaitState: this type is not properly added to typedefs.list in master as well. - pgoff_t: this is #define'd, and it appears that those typically do not show up in typedefs.list. Closest example I found was LOCKMODE, which is #define'd, but it is also typedef'd, giving it a fair excuse to exist in typedefs.list. pgoff_t does not exist in master's typedefs.list, and there is an oddly formatted line src/bin/pg_dump/pg_backup_archiver.c:2055:ReadOffset(ArchiveHandle *AH, pgoff_t * o) as a result. So the best choice here appears to be to not add it to typedefs.list, and once pgindent is run again, it will produce another oddly formatted line due to commit 6b6901a being different from master's version of it.
1 parent 0d8210c commit 769c7ef

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/tools/pgindent/typedefs.list

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -702,6 +702,7 @@ ExprEvalOp
702702
ExprEvalOpLookup
703703
ExprEvalRowtypeCache
704704
ExprEvalStep
705+
ExprSetupInfo
705706
ExprState
706707
ExprStateEvalFunc
707708
ExtensibleNode
@@ -1317,6 +1318,7 @@ JsonbTypeCategory
13171318
JsonbValue
13181319
JumbleState
13191320
JunkFilter
1321+
KAXCompressReason
13201322
KeyAction
13211323
KeyActions
13221324
KeyArray
@@ -3546,6 +3548,7 @@ plperl_proc_key
35463548
plperl_proc_ptr
35473549
plperl_query_desc
35483550
plperl_query_entry
3551+
plpgsql_CastExprHashEntry
35493552
plpgsql_CastHashEntry
35503553
plpgsql_CastHashKey
35513554
plpgsql_HashEnt
@@ -3590,6 +3593,7 @@ pull_varattnos_context
35903593
pull_varnos_context
35913594
pull_vars_context
35923595
pullup_replace_vars_context
3596+
pushdown_safe_type
35933597
pushdown_safety_info
35943598
qc_hash_func
35953599
qsort_arg_comparator

0 commit comments

Comments
 (0)