You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do a test run of pgindent, manually find types that should be in
typedefs.list, exclude any that do not also belong in the typedefs.list
of recent master (commit 8ede692 at the
time of writing), then add those types to typedefs.list.
Note the following types that were intentionally not included in the
list:
- ResultRelInfoExtra: introduced by commit
3706cc9, this type only exists in the
back-patch branch and not master.
- EPQStateExtra: introduced by commit
4729d1e, this type only exists in the
back-patch branch and not master.
- LWLockWaitState: this type is not properly added to typedefs.list in
master as well.
- pgoff_t: this is #define'd, and it appears that those typically do not
show up in typedefs.list. Closest example I found was LOCKMODE, which
is #define'd, but it is also typedef'd, giving it a fair excuse to
exist in typedefs.list. pgoff_t does not exist in master's
typedefs.list, and there is an oddly formatted line
src/bin/pg_dump/pg_backup_archiver.c:2055:ReadOffset(ArchiveHandle *AH, pgoff_t * o)
as a result. So the best choice here appears to be to not add it to
typedefs.list, and once pgindent is run again, it will produce another
oddly formatted line due to commit
6b6901a being different from master's
version of it.
0 commit comments