Skip to content

Tweak Producer Run #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Tweak Producer Run #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8917aeb
feat: update producer run
Cahllagerfeld May 7, 2025
e4850d0
feat: add auth required badge
Cahllagerfeld May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/app/runs/[id]/_Tabs/Overview/Orchestrator.tsx
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import ChevronDown from "@/assets/icons/chevron-down.svg?react";
import { CopyButton } from "@/components/CopyButton";
import { KeyValue } from "@/components/KeyValue";
import { AuthRequired } from "@/components/runs/auth-required";
import { usePipelineRun } from "@/data/pipeline-runs/pipeline-run-detail-query";
import { isString } from "@/lib/type-guards";
import { MetadataMap } from "@/types/common";
@@ -67,16 +68,19 @@ export function OrchestratorCollapsible() {
label="Orchestrator Logs"
value={
orchestrator_logs && isString(orchestrator_logs) ? (
<div className="group/copybutton flex items-center gap-0.5">
<a
className="truncate text-theme-text-brand underline transition-all duration-200 hover:decoration-transparent"
rel="noopener noreferrer"
target="_blank"
href={orchestrator_logs}
>
{orchestrator_logs}
</a>
<CopyButton copyText={orchestrator_logs} />
<div className="flex items-center gap-1">
<AuthRequired />
<div className="group/copybutton flex items-center gap-0.5">
<a
className="truncate text-theme-text-brand underline transition-all duration-200 hover:decoration-transparent"
rel="noopener noreferrer"
target="_blank"
href={orchestrator_logs}
>
{orchestrator_logs}
</a>
<CopyButton copyText={orchestrator_logs} />
</div>
</div>
) : (
"Not available"
16 changes: 5 additions & 11 deletions src/components/artifacts/artifact-node-sheet/DetailCards.tsx
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Pipelines from "@/assets/icons/pipeline.svg?react";
import Spinner from "@/assets/icons/spinner.svg?react";
import Run from "@/assets/icons/terminal-square.svg?react";
import { ComponentIcon } from "@/components/ComponentIcon";
import { DisplayDate } from "@/components/DisplayDate";
import { ErrorFallback } from "@/components/Error";
import { ExecutionStatusIcon, getExecutionStatusTagColor } from "@/components/ExecutionStatus";
@@ -24,7 +24,6 @@ import {
import { Link } from "react-router-dom";
import { Codesnippet } from "../../CodeSnippet";
import { CollapsibleCard } from "../../CollapsibleCard";
import { ComponentIcon } from "@/components/ComponentIcon";

type Props = {
artifactVersionId: string;
@@ -151,17 +150,12 @@ function ProducerKeys({ producerRunId }: { producerRunId: string }) {
value={
<Link to={routes.runs.detail(producerRunId)}>
<Tag
color={getExecutionStatusTagColor(pipelineRun.data.body?.status)}
className="inline-flex items-center gap-0.5"
rounded={false}
emphasis="subtle"
rounded={false}
className="inline-flex items-center gap-0.5"
color={getExecutionStatusTagColor(pipelineRun.data.body?.status)}
>
{pipelineRun.data.body?.status === "running" ? (
<Spinner className="mr-1 h-4 w-4 border-[2px]" />
) : (
<Run className={`mr-1 h-4 w-4 fill-current`} />
)}

<Run className={`mr-1 h-4 w-4 fill-current`} />
{producerRunId.split("-")[0]}
</Tag>
</Link>
35 changes: 35 additions & 0 deletions src/components/runs/auth-required.tsx
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import Triange from "@/assets/icons/alert-triangle.svg?react";
import {
Tag,
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger
} from "@zenml-io/react-component-library";

export function AuthRequired() {
return (
<TooltipProvider>
<Tooltip>
<TooltipTrigger>
<Tag
color="yellow"
className="flex items-center gap-0.5"
rounded={false}
emphasis="subtle"
>
<Triange className="h-4 w-4 shrink-0 fill-current" />
Login Required
</Tag>
</TooltipTrigger>
<TooltipContent>
<p>
You must be logged in for this link to work.
<br />
Please ensure you're signed in before accessing.
</p>
</TooltipContent>
</Tooltip>
</TooltipProvider>
);
}
24 changes: 14 additions & 10 deletions src/components/steps/step-sheet/DetailsTab.tsx
View file
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@ import { ErrorFallback } from "../../Error";
import { ExecutionStatusIcon, getExecutionStatusTagColor } from "../../ExecutionStatus";
import { Key, KeyValue, Value } from "../../KeyValue";
import { RepoBadge } from "../../repositories/RepoBadge";
import { AuthRequired } from "../../runs/auth-required";

type Props = {
stepId: string;
@@ -263,16 +264,19 @@ export function OrchestratorCard({ className }: { className?: string }) {
label="Orchestrator Logs"
value={
orchestrator_logs && isString(orchestrator_logs) ? (
<div className="group/copybutton flex items-center gap-0.5">
<a
className="truncate text-theme-text-brand underline transition-all duration-200 hover:decoration-transparent"
rel="noopener noreferrer"
target="_blank"
href={orchestrator_logs}
>
{orchestrator_logs}
</a>
<CopyButton copyText={orchestrator_logs} />
<div className="flex items-center gap-1">
<AuthRequired />
<div className="group/copybutton flex items-center gap-0.5">
<a
className="truncate text-theme-text-brand underline transition-all duration-200 hover:decoration-transparent"
rel="noopener noreferrer"
target="_blank"
href={orchestrator_logs}
>
{orchestrator_logs}
</a>
<CopyButton copyText={orchestrator_logs} />
</div>
</div>
) : (
"Not available"