[Call Stacks In Crash Reports] Per-frame redaction #979
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issackjohn
changed the title
|
@aluhrs13 @sethbrenith PTAL 😄 |
sethbrenith
approved these changes
Mar 11, 2025
aluhrs13
approved these changes
Mar 12, 2025
|
Just wondering, is this behavior going to be reproduced into Blink? AFAICT the full stack trace is redacted https://chromium-review.googlesource.com/c/chromium/src/+/6203432 instead of the selected frames (unclear if this divergence is intentional). |
|
Yes, the per-frame redaction behavior has already landed in Blink. You can find the landed CL here: https://chromium-review.googlesource.com/c/chromium/src/+/6287916. |
joone
pushed a commit
to joone/MSEdgeExplainers
that referenced
this pull request
May 9, 2025
* perf frame redaction * clean up language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
CrashReporting/AddStackToCrashReports.mdfile to improve the handling of stack frames in crash reports, particularly those involving extension scripts. The changes aim to enhance debugging while mitigating privacy concerns.Key changes:
<redacted>to preserve the rest of the call stack without revealing specific extension details.closes #945