Skip to content

MIC: Factor out iso grub.cfg processing and eliminate LiveOSIsoBuilder type #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

gmileka
Copy link
Contributor

@gmileka gmileka commented May 6, 2025

The last iteration of cleaning-up the LiveOS ISO generation code:

  • factor out iso grub.cfg processing code.
  • eliminate the LiveOSIsoBuilder abstraction to reduce state (state is now isolated in the IsoArtifactsStore type).

Checklist

  • [n/a] Tests added/updated
  • [n/a] Documentation updated (if needed)
  • Code conforms to style guidelines

@gmileka gmileka changed the title MIC: Factor raw image creation from iso artifacts + move population f… MIC: Factor our liveosiso grub.cfg processing and eliminate LiveOSIsoBuilder type May 6, 2025
@gmileka gmileka changed the title MIC: Factor our liveosiso grub.cfg processing and eliminate LiveOSIsoBuilder type MIC: Factor out liveosiso grub.cfg processing and eliminate LiveOSIsoBuilder type May 6, 2025
@gmileka gmileka changed the title MIC: Factor out liveosiso grub.cfg processing and eliminate LiveOSIsoBuilder type MIC: Factor out iso grub.cfg processing and eliminate LiveOSIsoBuilder type May 6, 2025
@gmileka gmileka marked this pull request as ready for review May 6, 2025 20:46
@gmileka gmileka requested a review from a team as a code owner May 6, 2025 20:47
@gmileka gmileka merged commit c419e78 into main May 7, 2025
7 checks passed
@gmileka gmileka deleted the user/gmileka/refactor_5 branch May 7, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants