Don't assert on empty send in datapath #2173
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Nov 22, 2021
thhous-msft
changed the title
nibanks
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1757
Doing some digging, this assert is benign. The only datapath this assert actually existed in was windows user mode. In all other datapaths, an empty send would have just made it down to the kernel as an empty send, and done nothing.
The original thought for a fix was to avoid an empty send at the core level, but we hit so many edge cases trying to fix there its a risky change and likely to skip the empty send at the wrong spot. We can still investigate that later, but for now this is a much safer fix.