Require powershell 7.2 for scripts susceptible to be run manually #4811
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
==========================================
- Coverage 87.38% 87.03% -0.36%
==========================================
Files 56 56
Lines 17400 17425 +25
==========================================
- Hits 15205 15165 -40
- Misses 2195 2260 +65 ☔ View full report in Codecov by Sentry. |
nibanks
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is easy to miss / forget about the powershell 7 requirement for running scripts, especially when Windows still ship with version 5.
This makes the script failure clearly indicate that the powershell version is the reason for the failures (versus the current undefined variables errors).
Resolves #4810
Testing
CI
Documentation
N/A