Skip to content

Resend CLOSE Frame in Closing State #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 4 tasks
nibanks opened this issue Mar 20, 2025 · 0 comments
Open
3 of 4 tasks

Resend CLOSE Frame in Closing State #4933

nibanks opened this issue Mar 20, 2025 · 0 comments
Labels
Bug: Core A code bug in the Core MsQuic code
Milestone

Comments

@nibanks
Copy link
Member

nibanks commented Mar 20, 2025

Describe the bug

Per spec (link):

An endpoint in the closing state sends a packet containing a CONNECTION_CLOSE frame in response to any incoming packet that it attributes to the connection.

An endpoint SHOULD limit the rate at which it generates packets in the closing state. For instance, an endpoint could wait for a progressively increasing number of received packets or amount of time before responding to received packets.

We don't seem to ever be sending a CLOSE frame beyond the first time we send it. So, in the case of packet loss the peer doesn't ever get the indication of connection closure. We should fix this.

Affected OS

  • Windows
  • Linux
  • macOS
  • Other (specify below)

Additional OS information

No response

MsQuic version

main

Steps taken to reproduce bug

Close a connection and then lose that first packet.

Expected behavior

The peer should usually get the close on a restrasmit.

Actual outcome

It never does

Additional details

No response

@nibanks nibanks added this to the Future milestone Mar 20, 2025
@nibanks nibanks added the Bug: Core A code bug in the Core MsQuic code label Mar 20, 2025
@nibanks nibanks changed the title Resent CLOSE Frame in Closing State Resend CLOSE Frame in Closing State Apr 24, 2025
@nibanks nibanks moved this to Planned in DPT Iteration Tracker Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Core A code bug in the Core MsQuic code
Projects
Status: Planned
Development

No branches or pull requests

1 participant