Skip to content

OneBranch Compiler Issue from MsQuic #797

@nibanks

Description

@nibanks
##[error]msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(90,25): Error C2059: syntax error: '}'

Ever since we ingested xdp v1.1 into MsQuic, it looks like our OneBranch build has been failing:

https://microsoft.visualstudio.com/undock/_build/results?buildId=116226118&view=logs&j=aa40dc91-88fa-5731-a169-ef58156bf447&t=bad3a4cd-6649-526a-a94e-bc001cc7b0e0&l=202

I think the problem is with the empty {} here:

typedef struct _XSK_BIND_IN {
    UINT32 IfIndex;
    UINT32 QueueId;
    XSK_BIND_FLAGS Flags;
} XSK_BIND_IN;

inline
XDP_STATUS
XskBind(
    _In_ HANDLE Socket,
    _In_ UINT32 IfIndex,
    _In_ UINT32 QueueId,
    _In_ XSK_BIND_FLAGS Flags
    )
{
    XSK_BIND_IN Bind = {};                    // <--- COMPILE ERROR

    Bind.IfIndex = IfIndex;

I believe we should either remove = {} or pass all the input variables inside the {}.

Note, there are several instances of this:

Build FAILED.

       "C:\__w\1\s\msquic\build\ALL_BUILD.vcxproj" (default target) (1) ->
       "C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj" (default target) (7) ->
       (ClCompile target) -> 
         C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(90,25): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
         C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(123,33): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
         C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(159,35): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
         C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(250,29): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
         C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(284,29): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]

Metadata

Metadata

Assignees

Labels

P1buildRelated to building/compiling the code

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions