-
Notifications
You must be signed in to change notification settings - Fork 52
Labels
Description
##[error]msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(90,25): Error C2059: syntax error: '}'
Ever since we ingested xdp v1.1 into MsQuic, it looks like our OneBranch build has been failing:
I think the problem is with the empty {}
here:
typedef struct _XSK_BIND_IN {
UINT32 IfIndex;
UINT32 QueueId;
XSK_BIND_FLAGS Flags;
} XSK_BIND_IN;
inline
XDP_STATUS
XskBind(
_In_ HANDLE Socket,
_In_ UINT32 IfIndex,
_In_ UINT32 QueueId,
_In_ XSK_BIND_FLAGS Flags
)
{
XSK_BIND_IN Bind = {}; // <--- COMPILE ERROR
Bind.IfIndex = IfIndex;
I believe we should either remove = {}
or pass all the input variables inside the {}
.
Note, there are several instances of this:
Build FAILED.
"C:\__w\1\s\msquic\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj" (default target) (7) ->
(ClCompile target) ->
C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(90,25): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(123,33): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(159,35): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(250,29): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
C:\__w\1\s\msquic\submodules\xdp-for-windows\published\external\xdp\details\afxdp.h(284,29): error C2059: syntax error: '}' [C:\__w\1\s\msquic\build\src\platform\msquic_platform.vcxproj]
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done