Fix Stress CI false negatives #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
reviewed
May 5, 2025
guhetier
previously approved these changes
May 5, 2025
mtfriesen
reviewed
May 6, 2025
mtfriesen
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #810 points out how the Stress CI succeeds even though one of it's intermediary steps failed.
This PR aims to ensure the entire job fails if any intermediary step fails.
Closes #810
Testing
CI
I made 2 draft PRs. One contains my fix and an intentional error: #840 (failing when it should)
One with an intentional error and without my fix: #841 (passing when it shouldn't)
Documentation
n/a
Installation
n/a