Skip to content

x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest) #61112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #60468
joedian opened this issue Jun 30, 2023 · 9 comments
Closed
Tracked by #60468

x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest) #61112

joedian opened this issue Jun 30, 2023 · 9 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Linux
Milestone
Unreleased

Comments

@joedian
Copy link

joedian commented Jun 30, 2023

No description provided.

@joedian joedian mentioned this issue Jun 30, 2023
Open
35 tasks
@joedian joedian added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder labels Jul 5, 2023
@joedian joedian changed the title host-linux-amd64-sid (Container Image: linux-x86-sid:latest) x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest) Jul 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 5, 2023
@heschi heschi closed this as completed Jul 25, 2023
@golang golang locked and limited conversation to collaborators Jul 24, 2024
@dmitshur
Copy link
Contributor

The build script was updated and a new LUCI-capable image was indeed built, though it's missing python3 (needed for the swarming bot). But we still need to add it to luci-config. Reopening for that.

@dmitshur dmitshur reopened this Apr 11, 2025
@golang golang unlocked this conversation Apr 11, 2025
@dmitshur dmitshur moved this to In Progress in Go Release Apr 11, 2025
@dmitshur dmitshur self-assigned this Apr 11, 2025
gopherbot pushed a commit to golang/build that referenced this issue Apr 15, 2025
@dmitshur @gopherbot
cmd/buildlet/stage0: update Dockerfile to use Go 1.24
b81ac1f 
The x/build module has 1.23.0 as its minimum, and 1.19 doesn't support
toolchain upgrades.

For golang/go#61112.

Change-Id: Ic1f7f71f415c126287e70ab18a27a94177e74a97
Reviewed-on: https://go-review.googlesource.com/c/build/+/665015
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665016 mentions this issue: env/linux-x86-sid: add python3 dependency

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665035 mentions this issue: main.star: add linux-amd64_debiansid

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665015 mentions this issue: cmd/buildlet/stage0: update Dockerfile to use Go 1.24

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665715 mentions this issue: internal/migration: stop running linux-{386,amd64}-sid builders

gopherbot pushed a commit to golang/build that referenced this issue Apr 16, 2025
@dmitshur @gopherbot
main.star: add linux-amd64_debiansid
811de21 
Move the linux-amd64-sid builder as it existed in the old infra to LUCI.

For golang/go#61112.

Change-Id: I31e3fda800c743b9aaedfaae1876ceef4b084691
Reviewed-on: https://go-review.googlesource.com/c/build/+/665035
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665856 mentions this issue: main.star: remove linux-{386,amd64}_debiansid known issues

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/665855 mentions this issue: main.star: add linux-386_debiansid

gopherbot pushed a commit to golang/build that referenced this issue Apr 16, 2025
@dmitshur @gopherbot
main.star: add linux-386_debiansid
6bac31e 
Move the linux-386-sid builder as it existed in the old infra to LUCI.

For golang/go#61112.

Change-Id: Ie78bc09c287af542d5968b57ff60f55c179b1a21
Reviewed-on: https://go-review.googlesource.com/c/build/+/665855
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
@prattmic prattmic mentioned this issue Apr 16, 2025
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/666035 mentions this issue: internal/relui, internal/task: keep parent PATH, add skip if no python3

gopherbot pushed a commit to golang/build that referenced this issue Apr 16, 2025
@dmitshur @gopherbot
internal/relui, internal/task: keep parent PATH, add skip if no python3
c8d31f7 
Improve the ability of tests to run in more environments. In the general
case, it's not viable to assume that replacing the parent environment's
PATH with '/bin:/usr/bin' will work, it can cause some commands like git
to be in PATH (defeating the t.Skip) yet its sub-commands can break.

Also add a missing skip when python3 isn't in PATH, since makeScript has
it as a dependency.

For golang/go#61112.

Change-Id: I623ed400c2f93c86f53e20ea7d7bfe04aefc2596
Cq-Include-Trybots: luci.golang.try:x_build-gotip-linux-amd64_debiansid
Reviewed-on: https://go-review.googlesource.com/c/build/+/666035
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Apr 17, 2025
@dmitshur @gopherbot
main.star: remove linux-{386,amd64}_debiansid known issues
48b2772 
They're working, and there are no more significant changes planned now.

Fixes golang/go#61112.

Change-Id: Icde0f7b2609572abc78acc1b6cbbdd8ab246da2f
Reviewed-on: https://go-review.googlesource.com/c/build/+/665856
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor

Closed by merging CL 665856 (commit golang/build@48b2772) to luci-config.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Apr 17, 2025
gopherbot pushed a commit to golang/build that referenced this issue Apr 17, 2025
@dmitshur @gopherbot
env/linux-x86-sid: add a Python 3 dependency
559ada5 
Needed for LUCI, and not implicitly installed. Though it turned out that
the python3 package on sid gets Python 3.13, and the latest swarming bot
version wasn't compatible with it, so use the python3.12 package for now.

Drop the 'mkdir --mode=0700 /run/sshd' call, SSH still works without it
and so it doesn't seem to be needed anymore. Keeping it can result in a
different error:

	Step 6/9 : RUN mkdir --mode=0700 /run/sshd
	 ---> Running in 47cf43748881
	mkdir: cannot create directory '/run/sshd': File exists
	The command '/bin/sh -c mkdir --mode=0700 /run/sshd' returned a non-zero code: 1

Install nano for minimal interactive debugging convenience while here.

For golang/go#61112.

Change-Id: I9ce538a9fe47d25988bddf879802ebe806b7eaff
Reviewed-on: https://go-review.googlesource.com/c/build/+/665016
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Apr 17, 2025
@dmitshur @gopherbot
internal/migration: stop running linux-{386,amd64}-sid builders
b220385 
These builders have been migrated to LUCI.

For golang/go#61112.
For golang/go#67761.

Change-Id: Ibf46c1983e57ab50d81960d860ea29729247d220
Reviewed-on: https://go-review.googlesource.com/c/build/+/665715
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Linux
Projects
Go Release
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @bcmills @gopherbot @joedian @heschi