net: TestDialGoogle uses IPv4 address with leading zeros

[rittneje]

Go version

go version go1.23.8 darwin/amd64

Output of go env in your module/workspace:

n/a

What did you do?

go test net -run=TestDialGoogle -tags=netgo -ipv4 -ipv6 -v

What did you see happen?

external_test.go:79: dial tcp: lookup 064.233.180.147: no such host

What did you expect to see?

It should not have tried to dial an IPv4 address with leading zeroes in a component, as that has been unsupported since Go 1.17.

go/src/net/external_test.go

Line 93 in adf21a9

"%03d.%03d.%03d.%03d:0080",

If this test is only supposed to be compatible with the cgo resolver, then it ought to have a guard clause for that.

[gabyhelp]

Related Issues

• net: Dial only tries one address, fails on IPv6-only system if that addr is IPv4 #8124 (closed)
• net: TestDialGoogle fails #13 (closed)
• net tests depend on external network #538 (closed)
• net: TestDialGoogle fails on "tcp6" address family #18 (closed)
• net: gotest fails with -ipv6=true option #1767 (closed)
• net: make Dial(listener.Addr().String()) always work, even if machine's IPv6 config is not ideal #18806 (closed)
• net: reject leading zeros in IP address parsers [freeze exception] #30999 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[prattmic]

cc @neild