Skip to content

x/pkgsite: version removal request for fyne.io/tools #73398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andydotxyz opened this issue Apr 16, 2025 · 3 comments
Closed

x/pkgsite: version removal request for fyne.io/tools #73398

andydotxyz opened this issue Apr 16, 2025 · 3 comments
Labels
Milestone

Comments

@andydotxyz
Copy link
Contributor

Hi Go team,

There was an accidental tag push on module fyne.io/tools (hosted at https://github.com/fyne-io/tools) which has been marked as retracted but the module metadata is not updating.
Can you please help?

The accidental tag was v1.26.0. The correct version is v1.6.0.
I marked the retraction in an updated release v1.6.1 https://github.com/fyne-io/tools/blob/v1.6.1/go.mod
However the "go get" command and package docs do not seem to recognise this retraction.
I pushed it yesterday so should not be a cache delay issue.

I would be grateful of your assistance to resolve this.

Thanks,
Andrew
(Maintainer of fyne.io)

@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2025
@seankhliao
Copy link
Member

There is nothing we can do to affect your versioning.
Note that retractions have to be published at a version higher than or equal to the versions they retract.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2025
@andydotxyz
Copy link
Contributor Author

Note that retractions have to be published at a version higher than or equal to the versions they retract.

Thank you for this, that is a key nugget which may be missing from the docs I read. I assumed "newer" would get read because the versions are added to the docs/proxy rather than "higher version" only. I'll check out a new higher version and report back if there are still go mod problems.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions

Apologies, I thought I was following steps in the documentation - an email address had been recommended which bounced so I followed the link about removal from page https://pkg.go.dev/about.

andydotxyz added a commit to fyne-io/tools that referenced this issue Apr 16, 2025
@andydotxyz
Copy link
Contributor Author

Thanks that fixed it. Just as a last thought, it could be worth making it clear in docs - the wording:

Retracting a module version involves adding a retract directive to your go.mod file and publishing a new version.

Could be ambiguous where what is meant is that the new version must be strictly a semver greater than the tag to be redacted. (https://pkg.go.dev/about)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants