-
Notifications
You must be signed in to change notification settings - Fork 280
chore: bump uuid lib #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
me4502
wants to merge
253
commits into
microsoft:releases/4.x
Choose a base branch
from
me4502:chore/bump-uuid-lib
base: releases/4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: bump uuid lib #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-version Add TFS 2017 Update 3 agent version.
Deep Dive on Building Custom Build or Deploy Tasks
* Add task.json schema file * Allow any "connectedService:" type of input * Added the "id" field
…cefiles Allow multiple resource files
Properly escape property value to handle non string types
* Error on multiline secret * v2.3.0
A part of the code was taken out from the `find` function to the new `_getStats` function. A new field `skipMissingFiles` was added into the `findOptions` parameter. When it is true, the `find` function skips files that were not found during the `_getStats` function execution. Also, the `mocktests` timeout increased from 15 to 30 seconds.
Fix Toolrunner Test "Should handle arguments with quotes properly"
Co-authored-by: Aleksandr Smolyakov <v-alsmo@microsoft.com>
* Added localization pipeline and LocProject.json * Removed en-US * Update localize-pipeline.yml for Azure Pipelines * Update localize-pipeline.yml for Azure Pipelines * Made letter case consistent for languages * LEGO: check in for Localization to temporary branch. (microsoft#703) * LEGO: check in for Localization to temporary branch. (microsoft#714) * LEGO: check in for Localization to temporary branch. (microsoft#720) * Temp renaming * Renamed localization files * Applied enhancements for the localization pipeline (microsoft#733) [skip ci] * [Localization] Fixed localization pipeline issue with already localized strings replaced (microsoft#737) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14646607 Localized file check-in by OneLocBuild Task * LEGO: check in for Localization to temporary branch. (microsoft#740) * LEGO: check in for Localization to temporary branch. (microsoft#741) * LEGO: check in for Localization to temporary branch. (microsoft#742) * LEGO: check in for Localization to temporary branch. (microsoft#743) * Temporary renamed files - to resolve conflicts * Temporary renamed * LEGO: check in for Localization to temporary branch. (microsoft#745) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#746) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#747) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#748) Co-authored-by: csigs <csigs@outlook.com> * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14905562 Localized file check-in by OneLocBuild Task * Returned back original names * Removed redundant locale - test * Removed redundant folders * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14906155 Localized file check-in by OneLocBuild Task * Returned back changes. Removed redundant * Create PR in OneLocBuild task only on third week of sprint (microsoft#755) * Fix localization pipeline * Add missed change * Added option to disable PR creation * Removing Localize folder Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: Egor Bryzgalov <v-egbryz@microsoft.com> Co-authored-by: csigs <csigs@outlook.com> Co-authored-by: Nikita Ezzhev <v-niezz@microsoft.com>
* change implicit check for explicit * bump patch version * bump package lock Co-authored-by: Ilya Kuleshov <v-ikuleshov@microsoft.com>
… function (microsoft#790) * fix doc, comment and condition * bumped version * bump version * fix documentation Co-authored-by: Anna Opareva <v-aopareva@microsoft.com> Co-authored-by: Simon Alling <SimonAlling@users.noreply.github.com>
…xceeded" (microsoft#773) * microsoft#667 Error setting resourceFile: "Maximum call stack size exceeded" + Preventing the infinite recustion by not translating warning about missing translation. * Wrong variable in warning output. - Getting rid of unnecessary escaping backslash * Bumping package version * Missing Localization test using mockery The missing file lib.json is simulated via resporting nonexistent file via mockery. Co-authored-by: Martin Šimek <martin.simek@digiteqautomotive.com> Co-authored-by: Anatoly Bolshakov <anatoly.bolshakov@akvelon.com>
* update dependencies
* Add HostException handler * Update error handling for HostException * Update vmImage for windows part * Update way of processing HostException * Change image to win 2019 * Fix naming
* Added new required functions. Return the value instead of the value or undefined. getInputRequired getPathInputRequired getEndpointUrlRequired getEndpointDataParameterRequired getEndpointAuthorizationSchemeRequired getEndpointAuthorizationParameterRequired * Fix undefined in json file * Simplify Required functions. Add tests. Co-authored-by: Keith Banner <keith.banner@inl.gov>
* added formatted proxy URL * version increment
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
* create new release/4.x branch * release for 4 version * update pipeline * update package.json * fix test and build commands * fixed tests on node18 * change image version for linux * fix test for linux * add separete test for linux * node v16.13 * add v16.13.0 to test * test on windows-2022, macOS-11 * separate branch for node16 * remove temporary code * update package.json * changed pipeline * updated pipeline * Microsoft mandatory file (microsoft#839)
…t#848) (microsoft#849) * Update pipeline * Update azure-pipelines.yml * nodeversion as variable
Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
* fix npm publish Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
me4502
added a commit
to me4502/azure-pipelines-task-lib
that referenced
this pull request
Oct 7, 2022
This is a backport of the fix from microsoft#867, but without bumping any versions or using fancy JS features such as destructuring as I'm unsure what node version this older package requires.
8524792
to
6bd15df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the UUID package to v8. Similar to this PR, #850, however this bumps to v8 rather than v7, and updates the code to address breaking changes. The other difference is my PR is targeting the latest release branch (4.x), rather than master which appears to still be on 3.x.
UUIDv8 is the final version to support NodeJS 10, which as far as I can tell is currently a required target for this project. If this isn't the case I'm happy to bump this to v9.
My motivation for this change is that this change, specifically the code change, make this code compatible with v9 at runtime. Due to an issue with versions of uuid prior to 9, jest tests cannot run correctly with the
jsdom
environment when uuid <=8 is in use. This can be resolved by the consuming app with yarn/npm resolutions to force v9 to be used, but as the code in this library is currently incompatible with v8 & v9 prior to this change, the resolution causes this to fail at runtime.