Skip to content

Update Falco README #20691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

Update Falco README #20691

merged 3 commits into from
Jul 15, 2025

Conversation

domalessi
Copy link
Contributor

What does this PR do?

https://datadoghq.atlassian.net/browse/DOCS-11418

Feedback:

When viewing the Falco Integration documentation, changing the site from the side panel does not update the intake URL. The intake should change based on the site, for EU should be:https://http-intake.logs.datadoghq.eu/api/v2/logs?dd-api-key=&ddsource=falco.

The exact functionality requested is not supported in integrations-core, so I went with a workaround. This PR replaces the specific URLs with placeholders and adds a note to clarity that the the placeholder must be updated according to your DD site.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

aliciascott
aliciascott previously approved these changes Jul 8, 2025
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

steveny91
steveny91 previously approved these changes Jul 14, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from aliciascott and steveny91 July 15, 2025 17:00

Review from aliciascott is dismissed. Related teams and files:

  • documentation
    • falco/README.md

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • falco/README.md
@domalessi domalessi added this pull request to the merge queue Jul 15, 2025
Merged via the queue into master with commit 0a3f7d4 Jul 15, 2025
58 of 61 checks passed
@domalessi domalessi deleted the domalessi/falco-update branch July 15, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants