Skip to content

Show diagnostics on abandoned cancellation token callback registration #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ycherkes
Copy link

@ycherkes ycherkes commented Apr 13, 2025

Abandoned cancellation token callback registration causes memory leaks.

Analyzer generates following diagnosticts for code:

// IDISP001 | Dispose created
using var cts = new CancellationTokenSource();
var token = cts.Token;CancellationTokenRegistration ctr = token.Register(() => client.CancelAsync());
// IDISP004 | Don't ignore created IDisposable
using var cts = new CancellationTokenSource();
var token = cts.Token;token.Register(() => client.CancelAsync());

MSDN

@ycherkes ycherkes changed the title Fix the cancellation token registration Fix the cancellation token callback registration Apr 13, 2025
@ycherkes ycherkes changed the title Fix the cancellation token callback registration Dispose the cancellation token callback registration Apr 13, 2025
@ycherkes ycherkes changed the title Dispose the cancellation token callback registration Raise diagnostics on abandoned cancellation token callback registration Apr 13, 2025
@ycherkes ycherkes changed the title Raise diagnostics on abandoned cancellation token callback registration Show diagnostics on abandoned cancellation token callback registration Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant