Skip to content

Merge Caches with Backends #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Merge Caches with Backends #1011

wants to merge 16 commits into from

Conversation

sakosha
Copy link

@sakosha sakosha commented Jun 17, 2025 •
edited
Loading

What do these changes do?

  • Merge MemoryBackend w/ MemoryCache.
  • Merge MemcachedBackend w/ MemcachedCache.
  • Merge ValkeyBackend w/ ValkeyCache.
  • Update tests to use ...Cache.
  • Add type annotations for these classes.
  • Add note to migrating docs.

Are there changes in behavior for the user?

  • Backend classes removed.
  • typing-extensions now a required dependency before 3.11

Related issue number

Fixes #684

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Dreamsorcerer
Dreamsorcerer reviewed Jun 17, 2025
View reviewed changes
@sakosha sakosha changed the title Merge MemoryBackend into MemoryCache, MemcachedBackend into MemcachedCache Merge Caches with Backends Jun 17, 2025
@sakosha sakosha requested a review from Dreamsorcerer June 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Awaiting requested review from Dreamsorcerer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge cache implementation classes for each backend
2 participants
@sakosha @Dreamsorcerer