KAFKA-19466: LogConcurrencyTest should close the log when the test completes; migrate LogConcurrencyTest #20110
+208
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpletes; migrate LogConcurrencyTest
github-actions
bot
added
triage
chia7712
reviewed
Jul 6, 2025
|
|
||
| validateConsumedData(log, consumer.getConsumedBatches()); | ||
| } finally { | ||
| executor.shutdownNow(); |
There was a problem hiding this comment.
should we wait for all threads to terminate?
storage/src/test/java/org/apache/kafka/storage/internals/log/LogConcurrencyTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/org/apache/kafka/storage/internals/log/LogConcurrencyTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/org/apache/kafka/storage/internals/log/LogConcurrencyTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public Void call() throws Exception { |
There was a problem hiding this comment.
the method getConsumedBatches could be removed if call returns List<FetchedBatch>
chia7712
reviewed
Jul 7, 2025
|
|
||
| @Test | ||
| public void testUncommittedDataNotConsumed() throws Exception { | ||
| testUncommittedDataNotConsumed(createLog()); |
There was a problem hiding this comment.
Yes, log is closed in the teardown method.
storage/src/test/java/org/apache/kafka/storage/internals/log/LogConcurrencyTest.java
Show resolved
Hide resolved
chia7712
reviewed
Jul 8, 2025
| ); | ||
| } | ||
|
|
||
| private record FetchedBatch(long baseOffset, int epoch) { |
There was a problem hiding this comment.
Perhaps it could be replaced by LinkedHashMap?
chia7712
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testUncommittedDataNotConsumed(), which call createLog() but never close
the log when the tests complete.
Reviewers: Chia-Ping Tsai chia7712@gmail.com