-
Notifications
You must be signed in to change notification settings - Fork 234
fix: Workflow Postgres #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Workflow Postgres #2913
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
``` | ||
|
||
</dd> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define Helm chart values to deploy Appsmith securely as a non-root user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 12-28 and replace it with the above line
type: RuntimeDefault | ||
|
||
applicationConfig: | ||
LD_PRELOAD: /usr/local/lib/libnss_wrapper.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is automatically handled by the Helm chart now. No need to set it explicitly. You can drop these two lines.
kubectl create secret docker-registry dockerhub \ | ||
--docker-username=<your-username> \ | ||
--docker-password=<your-password> \ | ||
--docker-email=<your-email> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While doing this is highly recommended and good practice, it's not unique to non-root setup. What do you think @pratapaprasanna should we just have a separate doc on this?
_image: | ||
repository: appsmith/appsmith-ee | ||
tag: latest | ||
pullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need the _image
block or any of the values in it, the defaults from the chart should work.
Description
Provide a concise summary of the changes made in this pull request
Pull request type
Check the appropriate box:
*
Documentation tickets
Link to one or more documentation tickets:
Checklist
From the below options, select the ones that are applicable: