carousel fix #2123
Open
carousel fix #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fyzanshaik <fyzan.shaik@gmail.com>
appwrite.ioProject ID: Note Cursor pagination performs better than offset pagination when loading further pages. |
Signed-off-by: fyzanshaik <fyzan.shaik@gmail.com>
|
The preview deployment failed. 🔴 Last updated at: 2025-06-30 10:18:14 CET |
TorstenDittmann
force-pushed
the
main
branch
5 times, most recently
from
6e3c6b4 to
83e3ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2122 where the Carousel component's navigation buttons did not correctly scroll the CodeCard components.
Changes Made:
scrollBy()movements.isStartandisEndstates (for button disabling) are correctly set immediately after component mount usingonMountandtick.display: grid;to the.carouselfor correctgrid-auto-flowbehavior.pointer-events: none;to::beforeand::afterpseudo-elements to prevent them from blocking clicks on carousel items.scroll-snap-align: start;to the internallistyles within the component.Test Plan
This is tested on my local development server and I have confirmed this fixes the issue. Attaching video below.
https://github.com/user-attachments/assets/8ef87ab1-e2c4-44f8-91bf-b369ce6c4076
Related PRs and Issues
This fixes issue #2122, no related PR's
Have you read the Contributing Guidelines on issues?
Yes I have read the CONTRIBUTING.md and made my contributions according to the guidelines.