Skip to content

Shared heap enhancement for AOT and update tests and samples #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 19, 2025
Merged

Shared heap enhancement for AOT and update tests and samples #4226

merged 29 commits into from
Jun 19, 2025
+1,356 −398

Conversation

TianlongLiang
Copy link
Collaborator

For AOT:

  • support preallocated shared heap and shared heap chain

For shared heap tests and samples:

  • enable AOT in sample and unit test
  • add more shared heap unit test cases, and enable shared heap unit test suite on X86_32 platform

@lum1n0us lum1n0us linked an issue May 18, 2025 that may be closed by this pull request
[RFC] Shared heap enhancements #4042
Open
@TianlongLiang
Copy link
Collaborator Author

The CI issue is due to the update of LLVM, which will be resolved after rebasing the dev branch

@TianlongLiang TianlongLiang marked this pull request as ready for review May 20, 2025 08:10
lum1n0us
lum1n0us reviewed May 29, 2025
View reviewed changes
core/iwasm/compilation/aot_emit_memory.c Outdated
LLVMBasicBlockRef check_succ, LLVMValueRef maddr_phi,
LLVMValueRef start_offset, LLVMValueRef max_addr,
LLVMValueRef mem_base_addr, LLVMValueRef bytes, uint32 bytes_u32,
bool is_memory64, bool is_target_64bit, bool bulk_memory, bool enable_segue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need comments to explain what each variable stands for.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add more comments in the new refactored function

core/iwasm/compilation/aot_emit_memory.c Outdated
LLVMBasicBlockRef check_succ, LLVMValueRef maddr_phi,
LLVMValueRef start_offset, LLVMValueRef max_addr,
LLVMValueRef mem_base_addr, LLVMValueRef bytes, uint32 bytes_u32,
bool is_memory64, bool is_target_64bit, bool bulk_memory, bool enable_segue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maynot a good idea to cover two types of memory overflow check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will break the common code to separate functions and create two functions for bulk memory and memory check, respectively

lum1n0us
lum1n0us requested changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix CI errors.

"""
LLVM ERROR: Instruction Combining did not reach a fixpoint after 1 iterations
"""

@TianlongLiang
Copy link
Collaborator Author

need to fix CI errors.

""" LLVM ERROR: Instruction Combining did not reach a fixpoint after 1 iterations """

The CI issue is due to the update of LLVM, which will be resolved after rebasing the dev branch

@lum1n0us
Copy link
Collaborator

lum1n0us commented Jun 11, 2025 •
edited
Loading

@TianlongLiang
shared heap enhancement: modify memory check for aot_check_memory_ove…
9747e00 
…rflow to accomodate shared heap chain
@TianlongLiang
first draft of shared heap enhancement in AOT
b0f0741
@TianlongLiang
fix some compilation issue
20cd6af
@TianlongLiang
use alloca for func ctx shared heap cache value
2f16e41
@TianlongLiang
use correct alloca for func ctx shared heap cache value
b58c75c
@TianlongLiang
enable shared heap chain aot test and bug fix
5de0ca3
@TianlongLiang
Fix a missing argument on 32bits platform, still has the shared heap …
106732b 
…chain iteration problem
@TianlongLiang
Fix shared heap chain iteration problem on 32bits platform
eaf2020
@TianlongLiang
fix AOT bulk memory bounds checks compliation issue
ae9d5ea
@TianlongLiang
fix AOT bulk memory bounds checks on 64 bits platform
86fbb8e
@TianlongLiang
refactor aot memory check
463b961
@TianlongLiang
refactor AOT bulk memory bounds checks
bc8dcd7
@TianlongLiang
update AOT bulk memory bounds checks
b5839c1
@TianlongLiang
update AOT bulk memory bounds checks
63de113
@TianlongLiang
update AOT bulk memory bounds check
9dff0fd
@TianlongLiang
fix typo
386dac3
@TianlongLiang
add more unit test for shared heap
f960e14
@TianlongLiang
finished organizing unit test for shared heap and enable x86_32 for s…
671c70a 
…hared heap unit test
@TianlongLiang
format
d332af5
@TianlongLiang
cover a corner case for bulk memory overflow check
e1432e4
@TianlongLiang
cover a corner case for bulk memory overflow check
ecfb609
@TianlongLiang
some update
5702a61
@TianlongLiang
try func call to replace shared heap chain traverse
7ddc5f8
@TianlongLiang
fix compilation error in JIT and potentially load nullptr
7cdd02e
@TianlongLiang
add option for wamrc to enable single shared heap/multi shared heap, …
b0415c0 
…and update shared heap unit tests and sample
@TianlongLiang
some refactor
a8f61a5
@TianlongLiang
format
6405cc2
@TianlongLiang
shared heap 32 bit platform unit test
3288983
@TianlongLiang
cr suggestions: 1. check potiential underflow 2. refactor and use sep…
8f49f86 
…arate function for bulk memory and normal memroy 3. static assert 4. add more comments 5. remove unused code
@TianlongLiang TianlongLiang force-pushed the dev/aot_shared_heap_enhancement branch from b57e280 to 8f49f86 Compare June 17, 2025 03:43
@lum1n0us lum1n0us merged commit ccdc836 into bytecodealliance:dev/shared_heap Jun 19, 2025
530 of 540 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Shared heap enhancements
2 participants
@TianlongLiang @lum1n0us