Remove unnecessary conversion of __wasi_addr_t to bh_sockaddr_t in sock_recv_from() #4391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sock_recv_from() `src_addr` will be filled upon return. Before the call, its content is unpredictable.
lum1n0us
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
TianlongLiang
approved these changes
Jun 19, 2025
lum1n0us
merged commit fc3e890
into
bytecodealliance:dev/zephyr_file_socket
307 of 375 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src_addrwill be filled upon return. Before the call, its content is unpredictable.fix a ci issue. https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/15731466177/job/44333440562#step:14:349