This repository was archived by the owner on Jul 31, 2023. It is now read-only.
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
stats/view: add Flush to immediately report all collected data points regardless of buffering #862
Open
Description
Problem:
When exiting a program running opencensus monitoring, some of the data are not passed to exporter. This happens because as one can see in following code, reportUsage() is called only by timer, so when program exists, all data passed to opencensus after last timer firing event are simply lost.
func (w *worker) start() {
for {
select {
case cmd := <-w.c:
cmd.handleCommand(w)
case <-w.timer.C:
w.reportUsage(time.Now())
case <-w.quit:
w.timer.Stop()
close(w.c)
w.done <- true
return
}
}
}
Solution proposal:
- Make
func (w *worker) stop()
to be (indirectly) callable by client of package. - Make
func (w *worker) start()
to callw.reportUsage()
before returning when<-w.quit
is triggered.