[Flight] Pass line/column to filterStackFrame
#33707
Merged
+27
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33706
filterStackFrame
implementations can fast-path ignore-listing by checking if the corresponding source map ignore-lists everything. However, this check requires checking every section for Index Source Maps which deopts the fast-path check from a constant check (comparing.length
) to looping through every section (i.e.O(N)
).By passing in the relevant line and column, a
filterStackFrame
implementation can find the relevant section with binary search (O(log N)
) e.g. https://github.com/vercel/next.js/blob/cc27c243af15703ee4f1bce2dd0afa6960a0f011/packages/next/src/server/lib/source-maps.ts#L60-L82