Skip to content

Make it less painful to update the types_test #1652

Open
@Stebalien

Description

@Stebalien

At the moment, updating the any of the miner types is really painful because we have hard-coded hex example serializations. We can fix this by:

  1. Removing the comments describing the CBOR structure. Keeping those up-to-date is going to be really annoying.
  2. Instead of decoding the examples from hex, encode the newly created cbor into hex then compare the hex (as strings). That way, we can update these values by copy-pasting from error messages (if and only if we actually expect them to change).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

📌 Triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions