-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(explore): Add support for apdex and user misery #94919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94919 +/- ##
========================================
Coverage 87.89% 87.89%
========================================
Files 10446 10446
Lines 604045 604157 +112
Branches 23517 23517
========================================
+ Hits 530913 531023 +110
- Misses 72769 72771 +2
Partials 363 363 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Threshold Casting Issue Affects APDEX Calculation
The apdex
and user_misery
functions cast the threshold
argument to int
, but their argument definitions allow "number" types (including floats). This causes float thresholds to be truncated, leading to a loss of precision in calculations.
src/sentry/search/eap/spans/formulas.py#L815-L816
sentry/src/sentry/search/eap/spans/formulas.py
Lines 815 to 816 in 8d5a551
response_time_field = cast(AttributeKey, args[0]) | |
threshold = cast(int, args[1]) |
src/sentry/search/eap/spans/formulas.py#L942-L943
sentry/src/sentry/search/eap/spans/formulas.py
Lines 942 to 943 in 8d5a551
response_time_field = cast(AttributeKey, args[0]) | |
threshold = cast(int, args[1]) |
Was this report helpful? Give feedback by reacting with 👍 or 👎
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_a4a619f6-4bca-45ee-a06f-edf7209024c4). |
Adds support for apdex and user misery. Note that the is_transaction filter is built into the formulas.