-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(ui): Add ellipsize
string helper
#94935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jonas <jonas.badalic@sentry.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94935 +/- ##
==========================================
- Coverage 87.93% 87.88% -0.05%
==========================================
Files 10455 10449 -6
Lines 606439 604345 -2094
Branches 23550 23550
==========================================
- Hits 533251 531109 -2142
- Misses 72821 72869 +48
Partials 367 367 |
@JonasBa thanks for the suggestions, accepted 🙏🏻 I also futzed a bit with the truncation behaviour, after thinking about it for a while. In short, I think it's acceptable to |
Was surprised that this helper doesn't exist? Maybe it does, but somewhere I didn't see it? Anyway I added a new one, y'all let me know what you want to call this thing, and if all the behaviour makes sense.