-
Notifications
You must be signed in to change notification settings - Fork 290
feat(credential-provider): support k8s service account token #8836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(credential-provider): support k8s service account token #8836
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mainred The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mainred any update on this PR? |
bff6efe
to
552713b
Compare
0419296
to
d11ecf3
Compare
@aramase, I have updated the PR description with my test and setup. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubernetes/enhancements#4412
Which issue(s) this PR fixes:
Fixes #8837
Tests I have been done
On a 1.33.0 cluster, I enabled workload identity on AKS cluster, and granted the identity, linked to the service account, permission to acrpull access.
I used the projected service account token azure-identity-token and get access token successfully
I then use the token the login the acr and pull the acr image successfully
docker login qingchuanhao.azurecr.io -u 00000000-0000-0000-0000-000000000000 -p <access-tokn>
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: