Skip to content

MHC should provide support for checking Machine conditions #5450

Open
@fabriziopandini

Description

@fabriziopandini

User Story

As a user/operator I would like to use MHC for checking machine conditions

Detailed Description

As of today MHC allows user to configure health checks on node conditions only.
It would be great to have MHC to support also definition of health checks on machine conditions, thus allowing e.g. to check on conditions about etcd/control plane components added by KCP.

Anything else you would like to add:
Most probably this requires changes to

UnhealthyConditions []UnhealthyCondition `json:"unhealthyConditions"`

And

type UnhealthyCondition struct {
// +kubebuilder:validation:Type=string
// +kubebuilder:validation:MinLength=1
Type corev1.NodeConditionType `json:"type"`
// +kubebuilder:validation:Type=string
// +kubebuilder:validation:MinLength=1
Status corev1.ConditionStatus `json:"status"`
Timeout metav1.Duration `json:"timeout"`
}

/kind feature
/kind api-change

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/featureCategorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.priority/backlogHigher priority than priority/awaiting-more-evidence.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions