Skip to content

Unit test failure: Reconcilliation should be incomplete #12301

Open
@alimaazamat

Description

@alimaazamat

Which jobs are flaking?

  • periodic-cluster-api-test-main
  • periodic-cluster-api-test-mink8s-main

Error:

{Failed  === RUN   TestReconcileNormalEtcd/create_pod_if_Node_is_ready
I0528 10:41:52.432149   71432 mux.go:340] "Workload cluster listener created" listenerName="foo" address="https://127.0.0.1:21000"
I0528 10:41:54.994721   71432 mux.go:544] "Etcd member added to WorkloadClusterListener" listenerName="foo" address="https://127.0.0.1:21000" podName="etcd-bar1"
    inmemorymachine_controller_test.go:368: 
        Expected
            <bool>: true
        to be false
--- FAIL: TestReconcileNormalEtcd/create_pod_if_Node_is_ready (2.58s)
}

Expects res to not be equal to zero but it is.
Failing Junit test TestReconcileNormalApiServer
Specifically the t.Run("create pod if Node is ready", func(t *testing.T) on this line here
It should return false not true for res equalling 0.

I see in that test the following line:
res, err := r.reconcileNormalAPIServer(ctx, cluster, cpMachine, inMemoryMachineWithNodeProvisioned)
So if res is equal to 0 then reconciliation will not be requeued, but it should be requeued and not equal to 0.

Which tests are flaking?

periodic-cluster-api-test-main
periodic-cluster-api-test-mink8s-main

Since when has it been flaking?

5/19/2025

Testgrid link

https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-test-main

Reason for failure (if possible)

No response

Anything else we need to know?

No response

Label(s) to be applied

/kind flake
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/flakeCategorizes issue or PR as related to a flaky test.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions