Skip to content

🌱 Bump tablewriter package version #12320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

Updates the github.com/olekukonko/tablewriter package to v1.0.7 version which contains some breaking changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12318

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from sivchari and vincepri June 5, 2025 06:12
@Karthik-K-N
Copy link
Contributor Author

Couple of things still pending

  1. The last child is not properly indented for example
Actual: 

Object/root             
├─Object/child1         
│ ├─Object/child1.1     
│ └─Object/child1.2     
└─Object/child2         
├─Object/child2.1       
└─Object/child2.2

Expected: 

Object/root
├─Object/child1
│ ├─Object/child1.1
│ └─Object/child1.2
└─Object/child2
  ├─Object/child2.1
  └─Object/child2.2
  1. Proper column padding vs cell padding, Replacing existing tbl.SetTablePadding(" ") setter
    Could not able to properly apply the change, will spend more time to get it correct
    Migration guide: https://github.com/olekukonko/tablewriter/blob/master/MIGRATION.md

@Karthik-K-N Karthik-K-N force-pushed the update-tablewriter branch 2 times, most recently from 349c487 to 9ac05f1 Compare June 5, 2025 11:15
@Karthik-K-N Karthik-K-N force-pushed the update-tablewriter branch from 9ac05f1 to ba61129 Compare June 5, 2025 11:16
@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-verify-main ba61129 link true /test pull-cluster-api-verify-main
pull-cluster-api-test-main ba61129 link true /test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Karthik-K-N
Copy link
Contributor Author

Couple of queries

  1. Not able to identify why the last child object is not getting indented
Actual: 

Object/root             
├─Object/child1         
│ ├─Object/child1.1     
│ └─Object/child1.2     
└─Object/child2         
├─Object/child2.1       
└─Object/child2.2

Expected: 

Object/root
├─Object/child1
│ ├─Object/child1.1
│ └─Object/child1.2
└─Object/child2
  ├─Object/child2.1
  └─Object/child2.2
  1. How should we deal with the errors coming from table.Render() and table.Append() are we supposed to ignore/log/ return back to parent functions? Looking forward for inputs. Thanks

tbl.SetTablePadding(" ")
tbl.SetNoWhiteSpace(true)
tbl.Options(
tablewriter.WithRowAutoWrap(tw.WrapNone),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved into table constructor while initializing, Once everything works as it is now, I will take care of simplifying it.

@Karthik-K-N
Copy link
Contributor Author

/cc @fabriziopandini @sbueringer

@sbueringer
Copy link
Member

sbueringer commented Jun 12, 2025

I'll defer to @fabriziopandini, but disclaimer, could take a bit until he gets around to it. We have to focus for a while on getting v1beta2 finished in time for this release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle error and solve lint error (everywhere)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github.com/olekukonko/tablewriter to v1+
4 participants