-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Bump tablewriter package version #12320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Couple of things still pending
|
349c487
to
9ac05f1
Compare
9ac05f1
to
ba61129
Compare
@Karthik-K-N: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Couple of queries
|
tbl.SetTablePadding(" ") | ||
tbl.SetNoWhiteSpace(true) | ||
tbl.Options( | ||
tablewriter.WithRowAutoWrap(tw.WrapNone), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be moved into table constructor while initializing, Once everything works as it is now, I will take care of simplifying it.
I'll defer to @fabriziopandini, but disclaimer, could take a bit until he gets around to it. We have to focus for a while on getting v1beta2 finished in time for this release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle error and solve lint error (everywhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thanks
What this PR does / why we need it:
Updates the
github.com/olekukonko/tablewriter
package to v1.0.7 version which contains some breaking changes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #12318