feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

SinaChavoshi · 2025-05-15T17:54:46Z

This PR introduces a new conformance test, HTTPRouteMultipleGatewaysDifferentPools, which validates a scenario where two distinct HTTPRoute resources, parented by different Gateway resources, successfully reference and route traffic to separate InferencePool backends.

local run results: ( Ran on commit 5990c51 )

go test -v ./conformance -args -debug     -gateway-class gke-l7-regional-external-managed     -cleanup-base-resources=false     -run-test HTTPRouteMultipleGatewaysDifferentPools
...
    suite.go:451: 2025-06-09T23:15:14.005553427Z: Sleeping 0s for test isolation
=== RUN   TestConformance/InferencePoolResolvedRefsCondition
    conformance.go:68: Skipping InferencePoolResolvedRefsCondition: test explicitly skipped
--- PASS: TestConformance (65.42s)
    --- SKIP: TestConformance/HTTPRouteInvalidInferencePoolRef (0.00s)
    --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (60.48s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Primary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (56.54s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Secondary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (0.54s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- SKIP: TestConformance/HTTPRouteMultipleRulesDifferentPools (0.00s)
    --- SKIP: TestConformance/InferencePoolResolvedRefsCondition (0.00s)
PASS
ok      sigs.k8s.io/gateway-api-inference-extension/conformance 65.623s

netlify · 2025-05-15T17:54:52Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`182ee70`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/685308ae819abf00081a85b6
😎 Deploy Preview	https://deploy-preview-838--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-05-15T17:54:56Z

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

spencerhance · 2025-05-16T18:16:20Z

/cc

spencerhance

/lgtm

conformance/conformance.go

spencerhance · 2025-05-19T18:22:08Z

/lgtm

ahg-g · 2025-05-20T15:14:53Z

/ok-to-test

danehans · 2025-06-16T16:21:02Z

/unhold

conformance/conformance.go

danehans · 2025-06-16T16:24:31Z

conformance/resources/manifests/manifests.yaml

+          periodSeconds: 5
+          failureThreshold: 2
+        env:
+        - name: POD_NAME


Is this var being used? If not, +1 to remove it.

danehans · 2025-06-16T16:24:44Z

conformance/resources/manifests/manifests.yaml

+          periodSeconds: 5
+          failureThreshold: 2
+        env:
+        - name: POD_NAME


Is this var being used? If not, +1 to remove it.

danehans · 2025-06-16T16:29:24Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.go

+			appBackendNamespace = "gateway-conformance-app-backend"
+			infraNamespace      = "gateway-conformance-infra"
+			backendAppLabelKey  = "app"
+
+			primaryGatewayName    = "conformance-gateway"
+			routeForPrimaryGWName = "route-for-primary-gateway"
+			primaryPoolName       = "primary-pool"
+			primaryBackendLabel   = "inference-model-1"
+			primaryRoutePath      = "/test-primary-gateway"
+
+			secondaryGatewayName    = "conformance-secondary-gateway"
+			routeForSecondaryGWName = "route-for-secondary-gateway"
+			secondaryPoolName       = "secondary-pool"
+			secondaryBackendLabel   = "inference-model-2"
+			secondaryRoutePath      = "/test-secondary-gateway"
+			secondaryRouteHostname  = "secondary.example.com"


conformance/resources/manifests/manifests.yaml defines resources that will be used across the tests, correct? If so, most of these locally defined consts should be public scope in the conformance/resources or conformance/resources/manifests pkg and imported into this test.

danehans · 2025-06-16T16:33:38Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml

+apiVersion: networking.gke.io/v1
+kind: HealthCheckPolicy
+metadata:
+  name: primary-pool-health-check
+  namespace: gateway-conformance-app-backend
+spec:
+  targetRef:
+    group: "inference.networking.x-k8s.io"
+    kind: InferencePool
+    name: primary-pool
+  default:
+    config:
+      type: HTTP
+      httpHealthCheck:
+          requestPath: /
+          port: 3000


HealthCheckPolicy is implementation-specific and should not be included in this test.

danehans · 2025-06-16T16:33:58Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml

+apiVersion: networking.gke.io/v1
+kind: HealthCheckPolicy
+metadata:
+  name: secondary-pool-health-check
+  namespace: gateway-conformance-app-backend
+spec:
+  targetRef:
+    group: "inference.networking.x-k8s.io"
+    kind: InferencePool
+    name: secondary-pool
+  default:
+    config:
+      type: HTTP
+      httpHealthCheck:
+          requestPath: /
+          port: 3000


danehans · 2025-06-16T16:34:34Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml

+  namespace: gateway-conformance-app-backend
+spec:
+  selector:
+    app: "inference-model-2"


nit: quoting is unneeded

danehans · 2025-06-16T16:36:34Z

conformance/tests/basic/inferencepool_multiple_rules_different_pools.go

@@ -0,0 +1,91 @@
+/*


This test is part of #834 and should be removed here, correct?

danehans · 2025-06-16T16:36:44Z

conformance/tests/basic/inferencepool_multiple_rules_different_pools.yaml

@@ -0,0 +1,183 @@
+---


This test is part of #834 and should be removed here, correct?

danehans · 2025-06-16T16:37:56Z

conformance/utils/config/timing.go

 		InferencePoolMustHaveConditionTimeout:  300 * time.Second,
 		InferencePoolMustHaveConditionInterval: 10 * time.Second,
 		GatewayObjectPollInterval:              5 * time.Second,
-		HTTPRouteDeletionReconciliationTimeout: 5 * time.Second,
+		HTTPRouteConditionTimeout:              300 * time.Second,


Since this condition timeout is the same as InferencePoolMustHaveConditionTimeout, consider using a single var that represents both resources, i.e. ConditionTimeout.

SinaChavoshi added 8 commits May 14, 2025 20:30

copy of accepted inference pool test to start from.

87d1756

add yaml file for the test

a9dcb62

update time out

c36e5f8

update the yaml file to add port 9002

aaf23e2

read timeout config from local repo

2a67e7d

remove excess comments

8ac7d72

copy from existing test to start with

c859896

update test and add gateway to main manifest

fe540a7

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2025

k8s-ci-robot requested review from nirrozenbaum and robscott May 15, 2025 17:54

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025

k8s-ci-robot requested a review from spencerhance May 16, 2025 18:16

spencerhance approved these changes May 16, 2025

View reviewed changes

conformance/conformance.go Show resolved Hide resolved

k8s-ci-robot assigned spencerhance May 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025

fix spelling error

63fedab

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025

SinaChavoshi added 3 commits May 20, 2025 17:02

correct spelling for scenarios

66f325d

check route condition on RouteConditionResolvedRefs

fd0fa10

check RouteConditionResolvedRefs instead of Reconciled

68812d7

zetxqx mentioned this pull request Jun 12, 2025

Conformance Tests for v0.5 Release #977

Open

12 tasks

SinaChavoshi added 3 commits June 13, 2025 19:17

Merge remote-tracking branch 'upstream/main'

117652e

Merge remote-tracking branch 'upstream/main' into inf_pool_tests_11

ad82e88

Merge remote-tracking branch 'upstream/main' into inf_pool_tests_12

ab4e4bc

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2025

danehans reviewed Jun 16, 2025

View reviewed changes

conformance/conformance.go Show resolved Hide resolved

danehans reviewed Jun 16, 2025

View reviewed changes

SinaChavoshi added 15 commits June 16, 2025 19:50

add to do for epp image

04f52f3

switch to GeneralMustHaveConditionTimeout

d6b588e

undo gateway version changes

112d878

remove unused HTTPRouteMustHaveConditions

120feb3

update doc string for GetPod

8214cdf

update docstring

76cb644

Merge branch 'inf_pool_tests_11' into inf_pool_tests_12

f50054f

fix defaults in timing.go

b235dbd

Remove resource type from names in manifests.

5dca67b

remove type from name

f2c0602

remove health check

daeb8e6

Merge remote-tracking branch 'upstream/main'

79b3015

Merge remote-tracking branch 'upstream/main' into inf_pool_tests_11

f1ab79f

add todo for combining getpod methods

81562a2

Merge branch 'inf_pool_tests_11' into inf_pool_tests_12

871d4d6

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025

SinaChavoshi added 2 commits June 17, 2025 21:46

Merge remote-tracking branch 'upstream'

ae33369

Merge branch 'main' into inf_pool_tests_12

43c1fa1

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2025

remove duplicate methods

182ee70

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Are you sure you want to change the base?

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Conversation

SinaChavoshi commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented May 15, 2025

Uh oh!

spencerhance commented May 16, 2025

Uh oh!

spencerhance left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spencerhance commented May 19, 2025

Uh oh!

ahg-g commented May 20, 2025

Uh oh!

danehans commented Jun 16, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SinaChavoshi commented May 15, 2025 •

edited

Loading

netlify bot commented May 15, 2025 •

edited

Loading