-
Notifications
You must be signed in to change notification settings - Fork 102
feat(conformance): Add HTTPRoute port validation tests for InferencePool backends #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zetxqx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @zetxqx! |
Hi @zetxqx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/ok-to-test |
@robscott This is also ready for review. Thanks in advance! |
type: PathPrefix | ||
value: /test-port-non-matching | ||
--- | ||
# --- Conformance EPP Requried Role and RoleBindings --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will be refactored to a common place. But for this PR itself, I would like to keep it as is for making the focus of this PR clear.
/test pull-gateway-api-inference-extension-test-e2e-main |
This warning message will need to be defined in Gateway API, so the standard message can be asserted in conformance tests. @robscott should we proceed with option 3 from the discussion until the message is standardized in v1.4 of Gateway API? |
IMO, "Gateway implementations put a warning on HTTPRoute status when HTTPRoute.BackendRef.Port is set and an InferencePool is targeted, saying that the port will be ignored" from option 5 is something that works now and in the future. After Gateway v1.4 is released, we won't be able to test this because Gateway API CRDs will prevent this from being possible, so maybe we should leave it out of conformance tests altogether. |
@robscott I agree with "we should leave it out of conformance tests altogether". The current PR doesn't have that check. So is it good to get a LG? |
Adds new conformance tests (InferencePoolHTTPRoutePortValidation) to verify HTTPRoute.spec.rules.backendRefs.port behavior with InferencePool backends. Covers scenarios for unspecified, matching, and non-matching ports.
This PR is originally from #887 to address #886. Based on the discussion #918 , now the test is updated to
HTTPRoute.BackendRef.Port
unspecified, gateway can send traffic successfully.HTTPRoute.BackendRef.Port
is set and equals toInferencePool.TargetPortNumber
, gateway can send traffic successfully.HTTPRoute.BackendRef.Port
is set and not equal toInferencePool.TargetPortNumber
, gateway can still send traffic successfully.One missing part is for case3, we need to verify there is warning in
httpRoute
mentioned in Option5 from #918Testing against istio:
Testing against gke-l7-regional-external-managed