-
Notifications
You must be signed in to change notification settings - Fork 115
fix(Conformance): Add namespace-(labels|annotations) flag parsing #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Conformance): Add namespace-(labels|annotations) flag parsing #984
Conversation
-namespace-labels key=value,k=v -namespace-annotations key=value,k=v
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @aslakknutsen! |
Hi @aslakknutsen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/assign @SinaChavoshi |
@ahg-g: GitHub didn't allow me to assign the following users: SinaChavoshi. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Thanks! |
@zetxqx: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
NamespaceLabels: namespaceLabels, | ||
NamespaceAnnotations: namespaceAnnotations, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SinaChavoshi will any of your outstanding PRs benefit from this change?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aslakknutsen, danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bernetes-sigs#984) -namespace-labels key=value,k=v -namespace-annotations key=value,k=v
…bernetes-sigs#984) -namespace-labels key=value,k=v -namespace-annotations key=value,k=v
-namespace-labels key=value,k=v
-namespace-annotations key=value,k=v