-
Notifications
You must be signed in to change notification settings - Fork 102
feat(flowcontrol): Add Foundational Types and Architecture #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(flowcontrol): Add Foundational Types and Architecture #997
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LukeAVanDrie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @LukeAVanDrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I have the followup PRs for the rest of the type system that contextualize this queued up, but I am currently on a 🚂 and my connection is spotty. Will send those out soon. The next PR will detail the |
/ok-to-test |
c86d3d8
to
0645012
Compare
Introduces the foundational packages for the new Flow Controller component. This change includes: - The top-level README outlining the motivation, high-level architecture, and component pillars. - The `types` package, which defines the core data contracts, request lifecycle interfaces, error-handling vocabulary, and final outcome enums for the entire module. This foundational PR establishes the core concepts and data models upon which the rest of the Flow Controller implementation will be built.
2c6952e
to
25a1e08
Compare
Description
This PR introduces the foundational building blocks for the new Flow Control system, designed to manage priority, fairness, and queuing for inference workloads.
The goal is to provide a sophisticated mechanism for managing diverse SLOs and preventing issues like Head-of-Line blocking and system overload, which are not addressed by simple FCFS temportal scheduling. This is a relatively sophisticated and complex system that will need to be split across several PRs. This initial submission lays the groundwork for the entire module by establishing its core concepts and data contracts (basically all types with no cross-package dependencies).
This work tracks issue #674
For historical context, the initial KEP-like proposal can be found here. Please note that the design has evolved significantly, and this PR represents the most current architecture (or at least a small slice of it). I will do some documentation cleanup once more of these PRs with the canonical architectural decisions are out for review.
Contribution
This PR includes two main pieces:
Top-Level README.md: Provides a high-level overview of the Flow Controller, including:
Controller
,Framework
,Registry
, etc.).The
types
Package: This new package establishes the core "vocabulary" for the entire Flow Controller module. It includes:FlowControlRequest
,QueueItemAccessor
,QueueItemHandle
).QueueOutcome
enum and a structured set of error types (ErrRejected
,ErrEvicted
).FlowSpecification
interface for defining workload identity and priority.README.md
detailing the concepts within the types package.Review Focus
As this is a foundational PR, I'm particularly looking for feedback on:
types
package clear, logical, and sufficient for the tasks ahead?QueueOutcome
, the error hierarchy) well-defined and intuitive?Future PRs will build upon these types to implement the
framework
,registry
, andcontroller
packages.