Skip to content

Add a Drifted condition to NodePool that tells whether any nodeclaims are drifted from the desired state #1785

Open
@reegnz

Description

@reegnz

Description

What problem are you trying to solve?

I'm trying to integrate karpenter nodepools into argocd health checks.
This would help argocd determine when a deployment of an ec2nodeclass or nodepool configuration change has been reconciled.

I think I could resolve this by writing a custom controller that adds an extra condition called Drifted to each NodePool resource, but I'd much rather have this solved natively by karpenter.

Proposal:

Introduce a new condition called Drifted with a value of False if the hashes of the NodeClaims managed by the NodePool do not match the hash of the NodePool and/or the Ec2NodeClass. The value should be True if any of the NodeClaims has a drifted hash of the NodePool or Ec2NodeClass.

Optionally there could be a status that tells how many nodeclaims we have that are drifted. If that count is 0 then the Drifted condition could be set to False.

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Activity

added
kind/featureCategorizes issue or PR as related to a new feature.
on Oct 29, 2024
added
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on Oct 29, 2024
reegnz

reegnz commented on Oct 29, 2024

@reegnz
Author

Originally opened here: aws/karpenter-provider-aws#7293

njtran

njtran commented on Nov 4, 2024

@njtran
Contributor

/triage accepted

added
triage/acceptedIndicates an issue or PR is ready to be actively worked on.
and removed
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.
on Nov 4, 2024
jonathan-innis

jonathan-innis commented on Mar 5, 2025

@jonathan-innis
Member

/help

k8s-ci-robot

k8s-ci-robot commented on Mar 5, 2025

@k8s-ci-robot
Contributor

@jonathan-innis:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

added
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
on Mar 5, 2025
jonathan-innis

jonathan-innis commented on Mar 5, 2025

@jonathan-innis
Member

/priority important-soon

added
priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.
on Mar 5, 2025
jonathan-innis

jonathan-innis commented on Mar 5, 2025

@jonathan-innis
Member

IMO, this is a really nice observability feature and could be a huge help for folks easily wanting to see if their NodeClaims are actively drifting -- we could even consider putting this in the printer column output.

flavono123

flavono123 commented on Mar 18, 2025

@flavono123
Contributor

how to deal for the new status if there is a single or any of nodeclaims with unknown drifted condition? as Unknown too?

flavono123

flavono123 commented on Mar 20, 2025

@flavono123
Contributor

/assign

dnutels

dnutels commented on Jul 8, 2025

@dnutels

Would it make sense to have DriftReason instead of True (ideally, if there are several reasons, a list of them) there as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @dnutels@reegnz@njtran@k8s-ci-robot@flavono123

    Issue actions

      Add a Drifted condition to NodePool that tells whether any nodeclaims are drifted from the desired state · Issue #1785 · kubernetes-sigs/karpenter